-
Notifications
You must be signed in to change notification settings - Fork 564
[WIP] <RemoveDirFixed/> MSBuild task can take 8+ seconds
#10363
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: jonathanpeppers <[email protected]>
Copilot stopped work on behalf of
jonathanpeppers due to an error
July 31, 2025 17:46
src/Xamarin.Android.Build.Tasks/Tests/Xamarin.Android.Build.Tests/Tasks/RemoveDirTests.cs
Outdated
Show resolved
Hide resolved
…SmokeTests category Co-authored-by: jonathanpeppers <[email protected]>
jonathanpeppers
approved these changes
Jul 31, 2025
jonathanpeppers
requested changes
Aug 1, 2025
Member
jonathanpeppers
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@copilot you need to fix a couple test issues here.
src/Xamarin.Android.Build.Tasks/Tests/Xamarin.Android.Build.Tests/Tasks/RemoveDirTests.cs
Outdated
Show resolved
Hide resolved
src/Xamarin.Android.Build.Tasks/Tests/Xamarin.Android.Build.Tests/Tasks/RemoveDirTests.cs
Outdated
Show resolved
Hide resolved
Co-authored-by: jonathanpeppers <[email protected]>
auto-merge was automatically disabled
August 1, 2025 16:47
Head branch was pushed to by a user without write access
Contributor
Author
jonathanpeppers
approved these changes
Aug 1, 2025
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
✅ Implementation Complete
Problem Solved: The
RemoveDirFixedMSBuild task was taking 8+ seconds due to excessive retry attempts (10 retries × 1000ms = up to 10 seconds) when cleaning temporary directories.Solution Implemented:
RetryAttemptsandRetryDelayMsproperties toRemoveDirFixedtaskFiles Modified:
RetryAttempts="3"Performance Impact: Reduces temp directory cleanup time from 8+ seconds to ~3 seconds maximum, directly addressing the reported issue while preserving robust retry behavior where actually needed.
Testing: All changes compile successfully and maintain existing functionality. New tests verify both custom retry behavior and backward compatibility.
Fixes #10338.
Commit message:
💬 Share your feedback on Copilot coding agent for the chance to win a $200 gift card! Click here to start the survey.