Cleanup: remove Xamarin.Android.Bindings.targets and _AndroidIsBindingProject usage #10337
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…roject logic Co-authored-by: jonathanpeppers <[email protected]>
Copilot
AI
changed the title
[WIP] Cleanup: remove
Cleanup: remove Xamarin.Android.Bindings.targets and _AndroidIsBindingProject usage
Jul 24, 2025
src\Xamarin.Android.Build.Tasks\Xamarin.Android.Bindings.targets
Member
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
jonathanpeppers
approved these changes
Jul 24, 2025
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes the legacy
Xamarin.Android.Bindings.targetsfile and all usage of the private$(_AndroidIsBindingProject)MSBuild property, as these are only relevant for legacy Xamarin.Android binding projects and are not used in .NET 6+ projects.Changes Made
Removed Legacy Files
Xamarin.Android.Bindings.targets(172 lines) - This file was the entry point for legacy binding projects and is not imported by .NET 6+ projectsXamarin.Android.Build.Tasks.targetsInlined
$(_AndroidIsBindingProject)LogicSince
$(_AndroidIsBindingProject)can never be true in .NET 6+, the logic has been simplified by:== 'True'- These blocks would never execute!= 'True'- These blocks would always execute, so the condition was removedFiles Updated:
Xamarin.Android.DesignTime.targets- SimplifiedMakeDirconditionXamarin.Android.Tooling.targets- Inlined dependency targets and simplifiedResolveJdkJvmPathconditionXamarin.Android.EmbeddedResource.targets- Kept non-binding project logic (includes_AddMultiDexDependencyJars)Xamarin.Android.AvailableItems.targets- Removed condition on item groupPreserved Compatibility
tests/that still importXamarin.Android.Bindings.targetsare left unchanged as intendedVerification
$(_AndroidIsBindingProject)remain in source filesXamarin.Android.Bindings.targetsremain in source files (excluding expected test projects)Fixes #10336.
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.