-
Notifications
You must be signed in to change notification settings - Fork 564
Modernize MSBuild Task Properties with Nullable Reference Types #10295
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: jonathanpeppers <[email protected]>
…o #nullable enable Co-authored-by: jonathanpeppers <[email protected]>
…able to #nullable enable Co-authored-by: jonathanpeppers <[email protected]>
…ntermediateClass.cs from #nullable disable to #nullable enable Co-authored-by: jonathanpeppers <[email protected]>
Copilot
AI
changed the title
[WIP] Modernize MSBuild Task Properties with Nullable Reference Types
Modernize MSBuild Task Properties with Nullable Reference Types
Jul 14, 2025
src/Xamarin.Android.Build.Tasks/Tasks/GenerateJniRemappingNativeCode.cs
Outdated
Show resolved
Hide resolved
src/Xamarin.Android.Build.Tasks/Tasks/GenerateJniRemappingNativeCode.cs
Outdated
Show resolved
Hide resolved
src/Xamarin.Android.Build.Tasks/Tasks/GenerateJniRemappingNativeCode.cs
Outdated
Show resolved
Hide resolved
src/Xamarin.Android.Build.Tasks/Tasks/GenerateJniRemappingNativeCode.cs
Outdated
Show resolved
Hide resolved
…ors, and simplify nullable patterns Co-authored-by: jonathanpeppers <[email protected]>
jonathanpeppers
approved these changes
Jul 15, 2025
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR systematically updates MSBuild task classes in
src/Xamarin.Android.Build.Tasks/Tasks/to follow the repository's nullable reference types guidelines fromcopilot-instructions.md.Changes Made
Successfully converted 5 MSBuild task files from
#nullable disableto#nullable enablewith proper nullable patterns:Files Updated:
Property Pattern Updates Applied:
Before:
After:
Additional Improvements:
string.IsNullOrEmpty()calls to extension method:property.IsNullOrEmpty()property ?? ""property!.Member= []instead ofArray.Empty<T>()Testing
Remaining Work
This is part of a larger effort to modernize all MSBuild tasks:
#nullable disableneed conversion#nullable enableaddedThe patterns established in this PR provide a template for completing the remaining modernization work.
Addressing #10277.
💬 Share your feedback on Copilot coding agent for the chance to win a $200 gift card! Click here to start the survey.