Skip to content

Conversation

@jonathanpeppers
Copy link
Member

@jonathanpeppers jonathanpeppers commented Jul 10, 2025

Fixes: #9701

A = symbol in the value of an environment variable does not appear to work in Debug mode with Fast Deployment enabled. This seems to be caused by the code in the <FastDeploy/> MSBuild task:

var items = line.Split(new char[] { '=' });
if (items.Length != 2)
    continue;

Introduce a test to verify a value such as: MONO_GC_PARAMS=bridge-implementation=new.

@jonathanpeppers jonathanpeppers changed the title [xabt] fix MONO_GC_PARAMS=major=marksweep env var [xabt] fix MONO_GC_PARAMS=bridge-implementation=new env var Jul 10, 2025
@jonathanpeppers
Copy link
Member Author

Ok, great the test reproduces the bug:

image

When Fast Deployment is ON, second param is False.

Fixes: #9701

A `=` symbol in the value of an environment variable does not appear
to work in Debug mode with Fast Deployment enabled. This seems to be
caused by the code in the `<FastDeploy/>` MSBuild task:

    var items = line.Split(new char[] { '=' });
    if (items.Length != 2)
        continue;

Introduce a test to verify a value such as:
`MONO_GC_PARAMS=bridge-implementation=new`.
@jonathanpeppers jonathanpeppers force-pushed the dev/peppers/MONO_GC_PARAMS branch from 923c0e8 to 49c9ff1 Compare July 11, 2025 13:17
@jonathanpeppers jonathanpeppers marked this pull request as ready for review July 11, 2025 13:17
@jonathanpeppers jonathanpeppers enabled auto-merge (squash) July 11, 2025 13:17
@jonathanpeppers jonathanpeppers merged commit 4fe5d41 into main Jul 11, 2025
59 checks passed
@jonathanpeppers jonathanpeppers deleted the dev/peppers/MONO_GC_PARAMS branch July 11, 2025 14:23
jonathanpeppers added a commit that referenced this pull request Jul 14, 2025
…w` env var (#10275)

Fixes: #9701

A `=` symbol in the value of an environment variable does not appear
to work in Debug mode with Fast Deployment enabled. This seems to be
caused by the code in the `<FastDeploy/>` MSBuild task:

    var items = line.Split(new char[] { '=' });
    if (items.Length != 2)
        continue;

Introduce a test to verify a value such as:
`MONO_GC_PARAMS=bridge-implementation=new`.

Bump to DevDiv/android-platform-support/release/9.0.1xx@709210ed

Changes: https://devdiv.visualstudio.com/DevDiv/_git/android-platform-support/branchCompare?baseVersion=GC0ec8d44d5d90dd2b8ab69cc9791e22da4ff16a52&targetVersion=GC709210edd65a679cd5a7b36c8e3a3140fba1c512

* [xabdt] fix env vars containing `=` sign

* [Xamarin.Installer.AndroidSDK] sort components before installing
jonathanpeppers added a commit that referenced this pull request Jul 14, 2025
…w` env var (#10275)

Fixes: #9701

A `=` symbol in the value of an environment variable does not appear
to work in Debug mode with Fast Deployment enabled. This seems to be
caused by the code in the `<FastDeploy/>` MSBuild task:

    var items = line.Split(new char[] { '=' });
    if (items.Length != 2)
        continue;

Introduce a test to verify a value such as:
`MONO_GC_PARAMS=bridge-implementation=new`.

Bump to DevDiv/android-platform-support/release/9.0.1xx@709210ed

Changes: https://devdiv.visualstudio.com/DevDiv/_git/android-platform-support/branchCompare?baseVersion=GC0ec8d44d5d90dd2b8ab69cc9791e22da4ff16a52&targetVersion=GC709210edd65a679cd5a7b36c8e3a3140fba1c512

* [xabdt] fix env vars containing `=` sign

* [Xamarin.Installer.AndroidSDK] sort components before installing
jonathanpeppers added a commit that referenced this pull request Jul 14, 2025
…w` env var (#10275)

Fixes: #9701

A `=` symbol in the value of an environment variable does not appear
to work in Debug mode with Fast Deployment enabled. This seems to be
caused by the code in the `<FastDeploy/>` MSBuild task:

    var items = line.Split(new char[] { '=' });
    if (items.Length != 2)
        continue;

Introduce a test to verify a value such as:
`MONO_GC_PARAMS=bridge-implementation=new`.

Bump to DevDiv/android-platform-support/release/9.0.1xx@709210ed

Changes: https://devdiv.visualstudio.com/DevDiv/_git/android-platform-support/branchCompare?baseVersion=GC0ec8d44d5d90dd2b8ab69cc9791e22da4ff16a52&targetVersion=GC709210edd65a679cd5a7b36c8e3a3140fba1c512

* [xabdt] fix env vars containing `=` sign

* [Xamarin.Installer.AndroidSDK] sort components before installing
jonathanpeppers added a commit that referenced this pull request Jul 15, 2025
…w` env var (#10275) (#10293)

Fixes: #9701

A `=` symbol in the value of an environment variable does not appear
to work in Debug mode with Fast Deployment enabled. This seems to be
caused by the code in the `<FastDeploy/>` MSBuild task:

    var items = line.Split(new char[] { '=' });
    if (items.Length != 2)
        continue;

Introduce a test to verify a value such as:
`MONO_GC_PARAMS=bridge-implementation=new`.

Bump to DevDiv/android-platform-support/release/9.0.1xx@709210ed

Changes: https://devdiv.visualstudio.com/DevDiv/_git/android-platform-support/branchCompare?baseVersion=GC0ec8d44d5d90dd2b8ab69cc9791e22da4ff16a52&targetVersion=GC709210edd65a679cd5a7b36c8e3a3140fba1c512

* [xabdt] fix env vars containing `=` sign

* [Xamarin.Installer.AndroidSDK] sort components before installing
@github-actions github-actions bot locked and limited conversation to collaborators Aug 11, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Compiler doesn't elaborate environment variable MONO_GC_PARAMS

2 participants