[native] Update list of BCL p/invokes #10155
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR updates the p/invoke dispatch tables for both MonoVM and CoreCLR to reflect new .NET10 changes (version 10.0.0-preview.6.25274.104). Key changes include:
- Increasing the dotnet_pinvokes array size from 477 to 491.
- Adding several new p/invoke entries (e.g., BrotliDecoderAttachDictionary, BrotliEncoderPrepareDictionary, etc.).
- Removing the deprecated SystemNative_SetWindowSize entry.
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| src/native/mono/pinvoke-override/pinvoke-tables.include | Updated array size and added new pinvoke entries for MonoVM. |
| src/native/mono/pinvoke-override/generate-pinvoke-tables.cc | Added new p/invoke names and removed SystemNative_SetWindowSize to match the updated dispatch table. |
| src/native/clr/host/pinvoke-tables.include | Updated CLR table size and new entries added along with removal of obsolete ones. |
| src/native/clr/host/generate-pinvoke-tables.cc | Adjusted the generated list to include new names and remove the outdated entry. |
Comments suppressed due to low confidence (1)
src/native/mono/pinvoke-override/generate-pinvoke-tables.cc:396
- Verify that the removal of 'SystemNative_SetWindowSize' from the generated list is intentional and that no existing consumers rely on this entry.
"SystemNative_SetWindowSize",
Update the MonoVM and CoreCLR p/invoke dispatch tables to include changes in .NET10, as of version `10.0.0-preview.6.25274.104`
grendello
force-pushed
the
dev/grendel/update-pinvokes-net10
branch
from
4d7a8cc to
819f382
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update the MonoVM and CoreCLR p/invoke dispatch tables to
include changes in .NET10, as of version
10.0.0-preview.6.25274.104