[CoreCLR] Support for fastdev assemblies #10113
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
grendello
force-pushed
the
dev/grendel/clr-host-fs-assemblies
branch
from
ec78c1f to
7d6817f
Compare
There was a problem hiding this comment.
Pull Request Overview
This PR adds support for fastdev assemblies and streamlines type mapping functionality while improving build target configuration. Key changes include:
- Introducing fastdev assemblies support with a new module for opening assemblies.
- Renaming and refactoring type mapping functions to use std::string_view with explicit length parameters.
- Updating build targets and tests to enable conditional use of the assembly store (CoreCLR and MonoVM).
Reviewed Changes
Copilot reviewed 30 out of 30 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| src/native/clr/include/constants.hh | Added a new constant DIR_SEP for directory separators. |
| src/native/clr/host/typemap.cc | Renamed and refactored type mapping functions and adjusted string conversions. |
| src/native/clr/host/internal-pinvokes.cc | Updated function calls to align with the updated type mapping API. |
| src/native/clr/host/host.cc | Integrated fastdev assemblies support in assembly probing logic. |
| src/native/clr/host/fastdev-assemblies.cc | New module for loading fastdev assemblies from an override directory. |
| src/Xamarin.Android.Build.Tasks/Xamarin.Android.Common.targets | Updated property definitions for assembly store usage. |
| Various files in Xamarin.Android.Build.Tasks/Utilities | Updated type mapping generators and XML adapters with new length/token fields. |
| Xamarin.Android.Build.Tasks/Tests | Updated tests and test case sources to account for CoreCLR and new parameters. |
src/Xamarin.Android.Build.Tasks/Tests/Xamarin.Android.Build.Tests/Utilities/DeviceTest.cs
Show resolved
Hide resolved
src/Xamarin.Android.Build.Tasks/Utilities/LlvmIrGenerator/LlvmIrGenerator.cs
Show resolved
Hide resolved
grendello
changed the title
Contributor
Author
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
grendello
force-pushed
the
dev/grendel/clr-host-fs-assemblies
branch
from
68d229d to
3de6409
Compare
Contributor
Author
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Contributor
Author
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Contributor
Author
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Contributor
Author
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
grendello
force-pushed
the
dev/grendel/clr-host-fs-assemblies
branch
from
06d1bda to
191622f
Compare
grendello
force-pushed
the
dev/grendel/clr-host-fs-assemblies
branch
5 times, most recently
from
3be5157 to
618486e
Compare
grendello
force-pushed
the
dev/grendel/clr-host-fs-assemblies
branch
from
618486e to
5ff2419
Compare
Contributor
Author
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
…IrGenerator.cs Co-authored-by: Copilot <[email protected]>
grendello
force-pushed
the
dev/grendel/clr-host-fs-assemblies
branch
from
5ff2419 to
29bef2d
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up to #10075