[XABT] Make NRT opt-out instead of opt-in. #10093
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jpobst
force-pushed
the
dev/jpobst/enable-xabt-nrt
branch
from
17d802b to
b95b11c
Compare
jpobst
requested review from
grendello,
jonathanpeppers and
jonpryor
as code owners
jonathanpeppers
approved these changes
Apr 30, 2025
Member
jonathanpeppers
left a comment
jonathanpeppers
left a comment
There was a problem hiding this comment.
This project has <WarningsAsErrors>Nullable</WarningsAsErrors>, so since the build is green it didn't add any new NRT warnings. 👍
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Help ensure we do not unintentionally add any additional non-NRT aware code to
Xamarin.Android.Build.Tasksby switching$(Nullable)fromannotationtoenable. This will subject any new files to NRT analysis by default unless they opt out with#nullable disable.To switch to this mode:
#nullable disableto any existing code files that have not been converted and currently have NRT warnings. (~200 files)#nullable enablefrom any existing code files that have already been converted. (~50 files)