[release/9.0.1xx] [build] use javac -source 17 -target 17 (#9493)
#10037
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Context: https://stackoverflow.com/a/76043133 Running `javac` with a newer `-source` and `-target` can run additional optimizations that results in *slightly* smaller Java bytecode and runtime performance. We should do this for all Java code we build as part of the product, as it might improve install size & build times for tools like `manifestmerger.jar` and `r8.jar`. After this change, I got the error: error: option -bootclasspath not allowed with target 17 Which is fixed by using `-classpath` instead.
Contributor
|
Note that this change adds a lot of warnings to our build: We probably need to determine if these are an issue before we ship them in a stable release. |
Member
Author
I'm trying |
Member
Author
|
Closing this in favor of backporting: I'll likely create a new PR to backport #10050 after it is merged to main. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of: #9493
Fixes: #9925
Context: https://stackoverflow.com/a/76043133
Running
javacwith a newer-sourceand-targetcan run additional optimizations that results in slightly smaller Java bytecode and runtime performance.We should do this for all Java code we build as part of the product, as it might improve install size & build times for tools like
manifestmerger.jarandr8.jar.After this change, I got the error:
Which is fixed by using
-classpathinstead.