Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: dotnet/android
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: 77e8707bd3
Choose a base ref
...
head repository: dotnet/android
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: 01024bb616
Choose a head ref
  • 2 commits
  • 3 files changed
  • 1 contributor

Commits on Oct 27, 2025

  1. [branding] updated product version to 36.1.x (#10557)

    Given that API 36.1 is "api stable", and we have a `$(TargetFramework)` available.
    
    We normally would also bump the product version to 36.1.x to signify this.
    
    `main` will remain `36.1.99-preview.1.x` for now, however it may need to change to 999.
    jonathanpeppers authored Oct 27, 2025
    Configuration menu
    Copy the full SHA
    38cdcbe View commit details
    Browse the repository at this point in the history

Commits on Oct 28, 2025

  1. [xabt] fix incremental design-time builds (#10564)

    Fixes: #10528
    Fixes: #10563
    
    There is a report in .NET 10 of *something* going wrong with
    incremental builds (and possibly design-time builds)...
    
    The app crashes with an error such as:
    
        android.content.res.Resources$NotFoundException: String resource ID #0x7f1000be at
        android.content.res.Resources.getText(Resources.java:466) at android.content.Context.getText(Context.java:933) at
        androidx.appcompat.widget.Toolbar.setNavigationContentDescription(Toolbar.java:1001) at
        crc64e02730b4d0e10e64.CustomShellRenderer_SectionRenderer.n_onCreateView(Native Method) at
        crc64e02730b4d0e10e64.CustomShellRenderer_SectionRenderer.onCreateView(CustomShellRenderer_SectionRenderer.java:36) ...
    
    Where the resource ID is invalid.
    
    After some debugging, after watching the video:
    
    * #10528 (comment)
    
    I was able to reproduce the issue, when I did:
    
    1. Open emulator
    2. Open project in VS
    3. Ctrl+F5 (see app running)
    4. Close VS (make sure emulator stays open)
    5. Reopen VS
    6. Ctrl+F5 again
    7. App crashes
    
    Reviewing builds logs, I saw this oddity on the design-time build on
    step 5:
    
        Target _GenerateRtxt
        Building target "_GenerateRtxt" completely.
        Input file "Bug.Dependency.csproj" does not exist.
    
    That is a referenced project file, it definitely should exist!
    
    However, I noticed the path is wrong:
    
        Target _CollectProjectReferenceResources
            Task MSBuild
                OutputItems
                    LibraryResourceDirectories
                        D:\src\dotnet-android-bug-10528\src\Bug.Dependency\Resources
                            StampFile = Bug.Dependency.csproj
    
    `%(StampFile)` is a relative path, which can be fixed via:
    
        StampFile="$(MSBuildProjectFile)"
        StampFile="$(MSBuildProjectFullPath)"
    
    This problem was introduced in .NET 10 via:
    
    * 9ed1469
    
    The target also uses `$(MSBuildProjectDirectory)`, which is a full path,
    so it is ok. See:
    
    * https://learn.microsoft.com/visualstudio/msbuild/msbuild-reserved-and-well-known-properties
    
    I was also able to reproduce this issue by adding a class library to
    the existing `BuildInDesignTimeMode()` test.
    jonathanpeppers committed Oct 28, 2025
    Configuration menu
    Copy the full SHA
    01024bb View commit details
    Browse the repository at this point in the history
Loading