Add Release compile step to PR pipelines#3864
Merged
paulmedynski merged 1 commit intomainfrom Jan 2, 2026
Merged
Conversation
- Added Release compilation to PR piplines to help avoid downstream pipeline errors.
paulmedynski
added
the
Area\Engineering
Contributor
There was a problem hiding this comment.
Pull request overview
This PR enhances the CI pipeline to compile code in both Debug and Release configurations during pull request validation, preventing downstream pipeline failures. It also fixes a compilation error in Release mode where a field was incorrectly wrapped in a DEBUG conditional.
- Added Release mode compilation step to PR pipelines when building in Debug mode
- Fixed Release mode compile error by removing DEBUG conditional from
s_packetIdfield declaration
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/Microsoft.Data.SqlClient/src/Microsoft/Data/SqlClient/ManagedSni/SniPhysicalHandle.netcore.cs | Removed DEBUG conditional compilation directive from s_packetId field since it's used outside DEBUG blocks |
| eng/pipelines/common/templates/jobs/ci-build-nugets-job.yml | Added conditional step to compile in Release mode when buildConfiguration is Debug |
The changes look good overall. The code fix correctly addresses a compilation issue where s_packetId was used on line 33 outside of any #if DEBUG block but was declared within one. The pipeline change is well-commented and follows a logical approach to catch Release-mode compilation issues early in the PR process.
apoorvdeshmukh
approved these changes
Jan 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Testing
The updated PR pipelines will now compile in Release in addition to Debug mode.