Change expected newline char when parsing crypto test baseline file.#3690
Merged
Change expected newline char when parsing crypto test baseline file.#3690
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR fixes CoreCryptoTests that were failing on Linux due to line ending differences. The tests parse baseline files containing keypairs, which use CRLF on Windows but are normalized to LF on Linux checkout.
- Updated regex pattern to look for LF (
\n) instead of CRLF (\r) when parsing parameter data - Adjusted baseline keypair files to use LF line endings (not visible in diff)
paulmedynski
previously approved these changes
Oct 14, 2025
...SqlClient/tests/ManualTests/AlwaysEncrypted/TestFixtures/Setup/CryptoNativeBaselineReader.cs
Show resolved
Hide resolved
mdaigle
changed the title
mdaigle
changed the title
src/Microsoft.Data.SqlClient/tests/ManualTests/AlwaysEncrypted/CoreCryptoTests.cs
Show resolved
Hide resolved
Member
|
I still see failures in Windows jobs in the linked build, is that expected? |
cheenamalhotra
approved these changes
Oct 15, 2025
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3690 +/- ##
==========================================
+ Coverage 77.34% 77.36% +0.02%
==========================================
Files 271 271
Lines 45245 45245
==========================================
+ Hits 34993 35003 +10
+ Misses 10252 10242 -10
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
priyankatiwari08
approved these changes
Oct 15, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
CoreCryptoTests fail when run on linux because line endings are normalized to LF when the repo is checked out. The tests are otherwise still applicable to linux and can pass when the "baseline" files containing the keypairs are properly parsed.
This PR:
Successful run: https://sqlclientdrivers.visualstudio.com/ADO.Net/_build/results?buildId=127269&view=results