Merge | Merge TdsParserStateObject, cleanup TdsParser files#3647
Merged
benrr101 merged 26 commits intodotnet:mainfrom Oct 13, 2025
Merged
Merge | Merge TdsParserStateObject, cleanup TdsParser files#3647benrr101 merged 26 commits intodotnet:mainfrom
benrr101 merged 26 commits intodotnet:mainfrom
Conversation
Contributor
|
Excited to get this one merged, but conflicts need addressing first :( (and they were probably caused by me anyhow...) |
benrr101
added
the
Common Project 🚮
Contributor
Author
|
Thanks - it looks like TdsParserStateObject had one instance of missing |
Contributor
|
/azp run |
|
Azure Pipelines successfully started running 2 pipeline(s). |
benrr101
approved these changes
Oct 8, 2025
Contributor
benrr101
left a comment
benrr101
left a comment
There was a problem hiding this comment.
Looks good to me, thanks for this heavy lifting
paulmedynski
approved these changes
Oct 8, 2025
Contributor
|
The CI errors appear to be transient, so I'll babysit this until it's green. |
Contributor
|
/azp run |
|
Azure Pipelines successfully started running 2 pipeline(s). |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3647 +/- ##
==========================================
- Coverage 77.21% 0 -77.22%
==========================================
Files 273 0 -273
Lines 46071 0 -46071
==========================================
- Hits 35574 0 -35574
+ Misses 10497 0 -10497
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
TdsParserStateObject currently comprises two target-specific files which have X differences:
All of the other methods in TdsParserStateObject.netfx.cs and .netcore.cs are identical. I've thus merged them into the shared TdsParserStateObject.cs file in one PR; this does make it a little larger, but it's hopefully easy enough to review.
This also mops up the trailing TdsParser.SSPI.cs file, which only have a few methods but was large enough that I didn't want to deal with it as part of the large TdsParser.cs merge.
Finally, there were a handful of now-unnecessary .stub.cs files, which I've pruned.
Each commit moves one or two methods for ease of review.
Issues
Relates to #1261.
Testing
Automated tests pass, could someone run CI please?