Merge | Port #528 and #2091 to netfx#3376
Conversation
|
/azp run |
|
Azure Pipelines successfully started running 2 pipeline(s). |
paulmedynski
left a comment
paulmedynski
left a comment
There was a problem hiding this comment.
A couple of spurious ? checks.
I didn't dig into the full logic that was added/modified - I don't have enough experience with SqlCommand for that yet.
src/Microsoft.Data.SqlClient/netcore/src/Microsoft/Data/SqlClient/SqlCommand.cs
Outdated
Show resolved
Hide resolved
src/Microsoft.Data.SqlClient/netfx/src/Microsoft/Data/SqlClient/SqlCommand.cs
Outdated
Show resolved
Hide resolved
|
/azp run |
|
Azure Pipelines successfully started running 2 pipeline(s). |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3376 +/- ##
==========================================
- Coverage 67.04% 58.80% -8.25%
==========================================
Files 300 292 -8
Lines 65376 65307 -69
==========================================
- Hits 43831 38403 -5428
- Misses 21545 26904 +5359
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
benrr101
left a comment
benrr101
left a comment
There was a problem hiding this comment.
Since this is porting changes into netfx, I'm onboard with these changes
src/Microsoft.Data.SqlClient/netfx/src/Microsoft/Data/SqlClient/SqlCommand.cs
Show resolved
Hide resolved
4 participants
Description
This ports an earlier set of memory usage reductions from netcore to netfx.
Issues
Relates to #1261.
Ports #528 and #2091.
Testing
Unit tests pass locally. I don't see anything specifically targeting these changes, so I assume that they're covered by the overall test suite - they're fairly frequently exercised.