Closed
Conversation
benrr101
added
Code Health 💊
- Move tests around to TestSet when necessary, consolidate AE test sets
Co-authored-by: Edward Neal <[email protected]>
Factor out tests that have different conditions
benrr101
force-pushed
the
dev/russellben/mz-enable-activeissue-tests
branch
from
4708a72 to
b5005bc
Compare
paulmedynski
requested changes
Apr 28, 2025
Contributor
paulmedynski
left a comment
paulmedynski
left a comment
There was a problem hiding this comment.
Duplicate method breaking compilation.
src/Microsoft.Data.SqlClient/tests/ManualTests/DataCommon/DataTestUtility.cs
Show resolved
Hide resolved
Contributor
Author
|
Just an update on this one - I'm running into one of the tests causing hanging after the tests complete. This seems to happen locally without the test even running. On debug, the check for azure synapse seems to be happening in a loop, so I'm trying to investigate what's causing that. |
paulmedynski
previously approved these changes
May 6, 2025
Contributor
|
/azp run |
|
Azure Pipelines will not run the associated pipelines, because the pull request was updated after the run command was issued. Review the pull request again and issue a new run command. |
Contributor
|
@benrr101 - Can you resolve the conflicts here? I think this is ready to merge otherwise. |
# Conflicts: # src/Microsoft.Data.SqlClient/tests/ManualTests/AlwaysEncrypted/CspProviderExt.cs # src/Microsoft.Data.SqlClient/tests/ManualTests/Microsoft.Data.SqlClient.ManualTesting.Tests.csproj
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a recreation of #3012 to resolve merges, rebase it off of main, and enable full CI builds. Original description is below
This PR activates a couple of tests that were marked with "ActiveIssue"
Upon trying them out, they seem to run fine.
Also does some minor improvements on a few tests or disable some tests on specific platform
Fixes #3035
This also fixes and allows to close the following ActiveIssue's in AzDO: