Revert "Test | Expose internal types to ManualTests"#3268
Merged
cheenamalhotra merged 1 commit intomainfrom Apr 10, 2025
Merged
Revert "Test | Expose internal types to ManualTests"#3268cheenamalhotra merged 1 commit intomainfrom
cheenamalhotra merged 1 commit intomainfrom
Conversation
This reverts commit 41b9345.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3268 +/- ##
==========================================
+ Coverage 72.81% 73.03% +0.22%
==========================================
Files 297 296 -1
Lines 59661 57254 -2407
==========================================
- Hits 43440 41817 -1623
+ Misses 16221 15437 -784
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
cheenamalhotra
approved these changes
Apr 10, 2025
benrr101
approved these changes
Apr 10, 2025
cheenamalhotra
deleted the
revert-3239-dev/mdaigle/expose-internals-to-tests
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reverts #3239
This change was causing confusion because it's only a partial solution and only works in Visual Studio.
Visual Studio build uses implementation assemblies, which contain internal types.
MSBuild uses the reference assemblies, which don't contain internal types.
We can reapply this change when we've updated our reference assemblies to include internal types.