netcore: sync exception messages with netfx

edwardneal · edwardneal · commit a8be2f1d5c9c · 2025-08-10T16:44:32.000+01:00
Messages of the netfx exceptions are more detailed
diff --git a/src/Microsoft.Data.SqlClient/netcore/src/Microsoft/Data/SqlClient/TdsParser.cs b/src/Microsoft.Data.SqlClient/netcore/src/Microsoft/Data/SqlClient/TdsParser.cs
@@ -964,7 +964,7 @@ private PreLoginHandshakeStatus ConsumePreLoginHandshake(
 
             if (_physicalStateObj._inBytesPacket > TdsEnums.MAX_PACKET_SIZE || _physicalStateObj._inBytesPacket <= 0)
             {
-                throw SQL.ParsingError();
+                throw SQL.ParsingError(ParsingErrorState.CorruptedTdsStream);
             }
             byte[] payload = new byte[_physicalStateObj._inBytesPacket];
 
@@ -2105,7 +2105,7 @@ internal TdsOperationStatus TryRun(RunBehavior runBehavior, SqlCommand cmdHandle
 #if DEBUG
                     throw new InvalidOperationException(message);
 #else
-                    throw SQL.ParsingError();
+                    throw SQL.ParsingErrorToken(ParsingErrorState.InvalidTdsTokenReceived, token); // MDAC 82443
 #endif
 
                 }
@@ -3674,7 +3674,7 @@ private TdsOperationStatus TryProcessSessionState(TdsParserStateObject stateObj,
         {
             if (length < 5)
             {
-                throw SQL.ParsingError();
+                throw SQL.ParsingErrorLength(ParsingErrorState.SessionStateLengthTooShort, length);
             }
             uint seqNum;
             TdsOperationStatus result = stateObj.TryReadUInt32(out seqNum);
@@ -3694,7 +3694,7 @@ private TdsOperationStatus TryProcessSessionState(TdsParserStateObject stateObj,
             }
             if (status > 1)
             {
-                throw SQL.ParsingError();
+                throw SQL.ParsingErrorStatus(ParsingErrorState.SessionStateInvalidStatus, status);
             }
             bool recoverable = status != 0;
             length -= 5;

Original file line number	Diff line number	Diff line change
`@@ -964,7 +964,7 @@ private PreLoginHandshakeStatus ConsumePreLoginHandshake(`
`964`	`964`
`965`	`965`	`if (_physicalStateObj._inBytesPacket > TdsEnums.MAX_PACKET_SIZE \|\| _physicalStateObj._inBytesPacket <= 0)`
`966`	`966`	`{`
`967`		`- throw SQL.ParsingError();`
	`967`	`+ throw SQL.ParsingError(ParsingErrorState.CorruptedTdsStream);`
`968`	`968`	`}`
`969`	`969`	`byte[] payload = new byte[_physicalStateObj._inBytesPacket];`
`970`	`970`
`@@ -2105,7 +2105,7 @@ internal TdsOperationStatus TryRun(RunBehavior runBehavior, SqlCommand cmdHandle`
`2105`	`2105`	`#if DEBUG`
`2106`	`2106`	`throw new InvalidOperationException(message);`
`2107`	`2107`	`#else`
`2108`		`- throw SQL.ParsingError();`
	`2108`	`+ throw SQL.ParsingErrorToken(ParsingErrorState.InvalidTdsTokenReceived, token); // MDAC 82443`
`2109`	`2109`	`#endif`
`2110`	`2110`
`2111`	`2111`	`}`
`@@ -3674,7 +3674,7 @@ private TdsOperationStatus TryProcessSessionState(TdsParserStateObject stateObj,`
`3674`	`3674`	`{`
`3675`	`3675`	`if (length < 5)`
`3676`	`3676`	`{`
`3677`		`- throw SQL.ParsingError();`
	`3677`	`+ throw SQL.ParsingErrorLength(ParsingErrorState.SessionStateLengthTooShort, length);`
`3678`	`3678`	`}`
`3679`	`3679`	`uint seqNum;`
`3680`	`3680`	`TdsOperationStatus result = stateObj.TryReadUInt32(out seqNum);`
`@@ -3694,7 +3694,7 @@ private TdsOperationStatus TryProcessSessionState(TdsParserStateObject stateObj,`
`3694`	`3694`	`}`
`3695`	`3695`	`if (status > 1)`
`3696`	`3696`	`{`
`3697`		`- throw SQL.ParsingError();`
	`3697`	`+ throw SQL.ParsingErrorStatus(ParsingErrorState.SessionStateInvalidStatus, status);`
`3698`	`3698`	`}`
`3699`	`3699`	`bool recoverable = status != 0;`
`3700`	`3700`	`length -= 5;`