First code review response

edwardneal · edwardneal · commit 9e11e7911716 · 2025-09-17T20:01:36.000+01:00
diff --git a/src/Microsoft.Data.SqlClient/src/Microsoft/Data/SqlClient/SqlConnection.cs b/src/Microsoft.Data.SqlClient/src/Microsoft/Data/SqlClient/SqlConnection.cs
@@ -24,12 +24,13 @@
 using Microsoft.Data.SqlClient.Diagnostics;
 using Microsoft.SqlServer.Server;
 #if NETFRAMEWORK
+using System.Runtime.CompilerServices;
 using System.Security.Permissions;
 using System.Security.Principal;
 #endif
 
 #if NETFRAMEWORK
-[assembly: System.Runtime.CompilerServices.InternalsVisibleTo("System.Data.DataSetExtensions, PublicKey=" + Microsoft.Data.SqlClient.AssemblyRef.EcmaPublicKeyFull)] // DevDiv Bugs 92166
+[assembly: InternalsVisibleTo("System.Data.DataSetExtensions, PublicKey=" + Microsoft.Data.SqlClient.AssemblyRef.EcmaPublicKeyFull)] // DevDiv Bugs 92166
 // NOTE: The current Microsoft.VSDesigner editor attributes are implemented for System.Data.SqlClient, and are not publicly available.
 // New attributes that are designed to work with Microsoft.Data.SqlClient and are publicly documented should be included in future.
 #endif
@@ -930,7 +931,7 @@ public int ServerProcessId
         {
             get
             {
-                if ((State & (ConnectionState.Open | ConnectionState.Executing | ConnectionState.Fetching)) > 0)
+                if ((State & (ConnectionState.Open | ConnectionState.Executing | ConnectionState.Fetching)) != 0)
                 {
                     return GetOpenTdsConnection().ServerProcessId;
                 }

Original file line number	Diff line number	Diff line change
`@@ -24,12 +24,13 @@`
`24`	`24`	`using Microsoft.Data.SqlClient.Diagnostics;`
`25`	`25`	`using Microsoft.SqlServer.Server;`
`26`	`26`	`#if NETFRAMEWORK`
	`27`	`+using System.Runtime.CompilerServices;`
`27`	`28`	`using System.Security.Permissions;`
`28`	`29`	`using System.Security.Principal;`
`29`	`30`	`#endif`
`30`	`31`
`31`	`32`	`#if NETFRAMEWORK`
`32`		`-[assembly: System.Runtime.CompilerServices.InternalsVisibleTo("System.Data.DataSetExtensions, PublicKey=" + Microsoft.Data.SqlClient.AssemblyRef.EcmaPublicKeyFull)] // DevDiv Bugs 92166`
	`33`	`+[assembly: InternalsVisibleTo("System.Data.DataSetExtensions, PublicKey=" + Microsoft.Data.SqlClient.AssemblyRef.EcmaPublicKeyFull)] // DevDiv Bugs 92166`
`33`	`34`	`// NOTE: The current Microsoft.VSDesigner editor attributes are implemented for System.Data.SqlClient, and are not publicly available.`
`34`	`35`	`// New attributes that are designed to work with Microsoft.Data.SqlClient and are publicly documented should be included in future.`
`35`	`36`	`#endif`
`@@ -930,7 +931,7 @@ public int ServerProcessId`
`930`	`931`	`{`
`931`	`932`	`get`
`932`	`933`	`{`
`933`		`- if ((State & (ConnectionState.Open \| ConnectionState.Executing \| ConnectionState.Fetching)) > 0)`
	`934`	`+ if ((State & (ConnectionState.Open \| ConnectionState.Executing \| ConnectionState.Fetching)) != 0)`
`934`	`935`	`{`
`935`	`936`	`return GetOpenTdsConnection().ServerProcessId;`
`936`	`937`	`}`