Copy PackageReferences to generated csproj#2347
Copy PackageReferences to generated csproj#2347AndreyAkinshin merged 3 commits intodotnet:masterfrom
Conversation
5af1cfc to
d50f562
Compare
Explicitly specify program entry point.
d50f562 to
85befa1
Compare
|
@timcassell could you please provide some explanations on why we actually have to copy the PackageReferences? Why the default NuGet transitive reference mechanism is not good enough for our use cases? |
|
Tbh, I'm not sure why. This was just an experiment I tried to fix the issue, and it worked for me, so I sent the PR. My guess is because the csproj is an output exe instead of dll, so the transitive references are skipped over. |
|
@timcassell I believe we should understand the source of the problem before merging any fixes. Could you please share a repro? |
Can you repro with my description in #2344? I didn't do anything fancy, just a simple |
|
@timcassell this issue is investigated, see my report in #2344 (comment) |
f4c02c1 to
66a04c4
Compare
66a04c4 to
e31672a
Compare
Added `PackageReference` to `SettingsWeWantToCopy`.
|
@timcassell thanks! |
|
This breaks if the |
Yeah... that was reported in #2364 |
Fixes #2344 and fixes #2259