IComparable for complex params#2304
Merged
AndreyAkinshin merged 7 commits intodotnet:masterfrom May 10, 2023
Merged
Conversation
adamsitnik
reviewed
May 10, 2023
Member
adamsitnik
left a comment
adamsitnik
left a comment
There was a problem hiding this comment.
Overall it LGTM, I just left one suggestion for improvement.
@mrahhal thank you for your contribution!
Member
|
It looks great, thanks! The only suggestion I have is about the intro example. We are trying to keep them as small as possible. I would suggest removing non-essential comments (e.g., "property with public setter", "public property") and simplifying some of the methods. E.g., instead public int CompareTo(ComplexParam other)
{
if (other == null)
{
return 1;
}
return Value.CompareTo(other.Value);
}we can write public int CompareTo(ComplexParam other) => other == null ? 1 : Value.CompareTo(other.Value); |
Member
|
@mrahhal could you please also rewrite |
Contributor
Author
|
Sure. Simplified it as much as I can. |
Member
|
@mrahhal thanks for your contribution! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
All the types in
PrimitiveComparerare actually alreadyIComparable, so I feel we can just remove this whole part altogether and have a single implementation that usesIComparable. Thoughts?Not sure if just removing it will replicate current behavior, since it does some stuff with enums, and it also even does a string comparison (which feels weird to me since there's already a string comparison in
ParameterComparer.Compare).Closes #2301