PHP 8.4 compat#3556
Conversation
swiffer
commented
Nov 23, 2024
- https://php.watch/versions/8.4/implicitly-marking-parameter-type-nullable-deprecated
|
supersedes #3508 |
|
We haven't yet deprecated support for PHP 7.1 through so you can't yet mark properties nullable. Otherwise looks good. Can you also add PHP 8.4 to the test runner? |
|
ok, should PHP 7.1 / 7.2 / 7.3 support be restored or is it going to be deprecated considering it's EOL since 2018/19/20? |
|
I do plan to drop PHP support before version 8.0 at some point, but I wasn't pro-actively doing so just yet. We'll eventually want or need to use features that aren't available in earlier versions, at which point we'll definitely bump the minimum version. I want to make this part of a minor release since it doesn't impact compatibility with existing installations. I prefer to drop PHP version support in a major release to ensure the requirement change is obvious. I know that's not strictly necessary, but using a major release to bump version requirements helps avoid confusion by end users. Considering the significant decline in PHP 7 usage the next major release is likely to drop support. All that to say, can you go ahead and restore support? |
|
ok, done - thanks for the detailed reply! |
|
Nicely done thanks for working on this. |
|
Thank you for this. Do you have plans to make a release which includes this PR any time soon? |
|
Yes, looking to release a new version soon. |
Is it possible to integrate this: Can I help with something? |
|
@wblessen not with the PHP compatibility update, which I am going to push through this week. But I will look to try and finish up that for release soon as well. Feel free to review the changes and make suggestions if you are able. |
|
Thank you for all your work! I will try to move the changes in a pull request with the current source this week |