Skip to content

PHP 8.4 compat#3556

Merged
bsweeney merged 3 commits intodompdf:masterfrom
swiffer:php84-compat
Nov 23, 2024
Merged

PHP 8.4 compat#3556
bsweeney merged 3 commits intodompdf:masterfrom
swiffer:php84-compat

Conversation

@swiffer
Copy link
Copy Markdown
Contributor

@swiffer swiffer commented Nov 23, 2024

@swiffer
Copy link
Copy Markdown
Contributor Author

swiffer commented Nov 23, 2024

supersedes #3508

@bsweeney
Copy link
Copy Markdown
Member

bsweeney commented Nov 23, 2024

We haven't yet deprecated support for PHP 7.1 through so you can't yet mark properties nullable. Otherwise looks good.

Can you also add PHP 8.4 to the test runner?

@swiffer
Copy link
Copy Markdown
Contributor Author

swiffer commented Nov 23, 2024

ok, should PHP 7.1 / 7.2 / 7.3 support be restored or is it going to be deprecated considering it's EOL since 2018/19/20?

@bsweeney
Copy link
Copy Markdown
Member

bsweeney commented Nov 23, 2024

I do plan to drop PHP support before version 8.0 at some point, but I wasn't pro-actively doing so just yet. We'll eventually want or need to use features that aren't available in earlier versions, at which point we'll definitely bump the minimum version.

I want to make this part of a minor release since it doesn't impact compatibility with existing installations. I prefer to drop PHP version support in a major release to ensure the requirement change is obvious. I know that's not strictly necessary, but using a major release to bump version requirements helps avoid confusion by end users.

Considering the significant decline in PHP 7 usage the next major release is likely to drop support.

All that to say, can you go ahead and restore support?

@swiffer
Copy link
Copy Markdown
Contributor Author

swiffer commented Nov 23, 2024

ok, done - thanks for the detailed reply!

@bsweeney
Copy link
Copy Markdown
Member

Nicely done thanks for working on this.

@bsweeney bsweeney merged commit 8922f33 into dompdf:master Nov 23, 2024
@bsweeney bsweeney linked an issue Nov 23, 2024 that may be closed by this pull request
@bsweeney bsweeney added this to the 3.0.1 milestone Nov 23, 2024
@8ctopus 8ctopus mentioned this pull request Nov 25, 2024
@oleibman
Copy link
Copy Markdown

oleibman commented Dec 1, 2024

Thank you for this. Do you have plans to make a release which includes this PR any time soon?

@bsweeney
Copy link
Copy Markdown
Member

bsweeney commented Dec 1, 2024

Yes, looking to release a new version soon.

@wblessen
Copy link
Copy Markdown

wblessen commented Dec 2, 2024

Yes, looking to release a new version soon.

Is it possible to integrate this:

#3269

Can I help with something?

@bsweeney
Copy link
Copy Markdown
Member

bsweeney commented Dec 2, 2024

@wblessen not with the PHP compatibility update, which I am going to push through this week. But I will look to try and finish up that for release soon as well. Feel free to review the changes and make suggestions if you are able.

@wblessen
Copy link
Copy Markdown

wblessen commented Dec 3, 2024

Thank you for all your work!

I will try to move the changes in a pull request with the current source this week

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Php 8.4 Deprecation of Non-nullable Parameters Defaulting to null

4 participants