ssa: don't crash in conversions that ignore struct tags

dominikh · dominikh · commit 769824fffc06 · 2017-04-21T22:39:38.000+02:00
Closes gh-77
diff --git a/ssa/emit.go b/ssa/emit.go
@@ -149,7 +149,7 @@ func emitCompare(f *Function, op token.Token, x, y Value, pos token.Pos) Value {
 //
 func isValuePreserving(ut_src, ut_dst types.Type) bool {
 	// Identical underlying types?
-	if types.Identical(ut_dst, ut_src) {
+	if structTypesIdentical(ut_dst, ut_src) {
 		return true
 	}
 
diff --git a/ssa/identical.go b/ssa/identical.go
@@ -0,0 +1,7 @@
+// +build go1.8
+
+package ssa
+
+import "go/types"
+
+var structTypesIdentical = types.IdenticalIgnoreTags
diff --git a/ssa/identical_17.go b/ssa/identical_17.go
@@ -0,0 +1,7 @@
+// +build !go1.8
+
+package ssa
+
+import "go/types"
+
+var structTypesIdentical = types.Identical

Original file line number	Diff line number	Diff line change
`@@ -149,7 +149,7 @@ func emitCompare(f *Function, op token.Token, x, y Value, pos token.Pos) Value {`
`149`	`149`	`//`
`150`	`150`	`func isValuePreserving(ut_src, ut_dst types.Type) bool {`
`151`	`151`	`// Identical underlying types?`
`152`		`- if types.Identical(ut_dst, ut_src) {`
	`152`	`+ if structTypesIdentical(ut_dst, ut_src) {`
`153`	`153`	`return true`
`154`	`154`	`}`
`155`	`155`