Fix #1319: DB Connection buffer classes must be retained on deployment#1322
Merged
blairmcg merged 1 commit intorelease/7.2from Feb 3, 2025
Merged
Fix #1319: DB Connection buffer classes must be retained on deployment#1322blairmcg merged 1 commit intorelease/7.2from
blairmcg merged 1 commit intorelease/7.2from
Conversation
DBColAttr class>>#initialize is the only reference in code to the database buffer classes, and so must not be stripped or the buffer classes will be removed. A new package closure test is included, but unfortunately the closure test mechanism isn't sophisticated enough to catch this particular fault because it only finds missing code caused by the calculation of the transitive closure of packages required for an application. It does not account for code removed by the deployment process that iteratively removes (supposedly) unreferenced methods and classes, as this is difficult to simulate. It looks possible to create a better test simulation using RB environments than the simplistic approach currently employed, but it is not easy, and in the meantime this corrects the particular case of the apps using Database Connection not working after deployment.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
DBColAttr class>>#initialize is the only reference in code to the database buffer classes, and so must not be stripped or the buffer classes will be removed.
A new package closure test is included, but unfortunately the closure test mechanism isn't sophisticated enough to catch this particular fault because it only finds missing code caused by the calculation of the transitive closure of packages required for an application. It does not account for code removed by the deployment process that iteratively removes (supposedly) unreferenced methods and classes, as this is difficult to simulate. It looks possible to create a better test simulation using RB environments than the simplistic approach currently employed, but it is not easy, and in the meantime this corrects the particular case of the apps using Database Connection not working after deployment. I plan to do some further work in this in the Dolphin 8 branch, but I probably won't back port it.