Simple negative floats not scanned correctly (sign lost)#1264
Merged
blairmcg merged 2 commits intorelease/7.1from Dec 29, 2023
Merged
Simple negative floats not scanned correctly (sign lost)#1264blairmcg merged 2 commits intorelease/7.1from
blairmcg merged 2 commits intorelease/7.1from
Conversation
The SmalltalkScanner used for refactorings, live error reporting and some other IDE purposes, loses the sign of simple negative floats. This hasn't mattered much to date because the literal values generated are not consumed, e.g. when an AST is used to reformat code, the original number syntax is preserved. To Reproduce evaluate: (SmalltalkScanner on: '-1.23' readStream) next value "=> 1.23" Obviously the result should be -1.23. 1-line fix and test value update in 8. For 7.1, ported over most of the ScannerTest class from 8.
Too dependent on network config of the host
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The SmalltalkScanner used for refactorings, live error reporting and some other IDE purposes, loses the sign of simple negative floats. This hasn't mattered much to date because the literal values generated are not consumed, e.g. when an AST is used to reformat code, the original number syntax is preserved.
To Reproduce evaluate:
(SmalltalkScanner on: '-1.23' readStream) next value "=> 1.23"
Obviously the result should be -1.23.
1-line fix and test value update in 8. For 7.1, ported over most of the ScannerTest class from 8.