Drag/drop method over class/instance mode radio button fails#1256
Merged
blairmcg merged 2 commits intorelease/7.1from Dec 23, 2023
Merged
Drag/drop method over class/instance mode radio button fails#1256blairmcg merged 2 commits intorelease/7.1from
blairmcg merged 2 commits intorelease/7.1from
Conversation
Drag/drop of a method over the class/instance mode button can be used to copy/move an instance method to the class side, and vice versa. This fails leaving behind the drag/drop cursor, opening a hidden walkback window. Turns out to be a bug introduced by f20d139
Also, Frank Lesser reported to me a couple of years ago that DragDropSession was not initialized properly causing a potential issue in #isInDropTargetScrollZone:. It works because the implementation of Boolean>>#eqv: uses #==, but the inst var should be false initially.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Drag/drop of a method over the class/instance mode button can be used to copy/move an instance method to the class side, and vice versa. This fails leaving behind the drag/drop cursor, opening a hidden walkback window. Turns out to be a bug introduced by f20d139
Fix cherry-picked from Dolphin 8 commit 8b917af