Use menuPopulator: annotations to build drop-down toolbar menus too#1249
Merged
Use menuPopulator: annotations to build drop-down toolbar menus too#1249
Conversation
We can also use the menuPopulator: mechanism to provide a generic implementation to populate and show menus for drop-down toolbar buttons. This removes the need to hook the dropDown: event, to switch on the toolbar button command symbol, and to reproduce the code to show a menu everywhere used.
blairmcg
force-pushed
the
blairmcg/toolbardropdowns
branch
from
8c3f50d to
ed5ede3
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We can also use the menuPopulator: mechanism to provide a generic implementation to populate and show menus for drop-down toolbar buttons. This removes the need to hook the dropDown: event, to switch on the toolbar button command symbol, and to reproduce the code to show a menu everywhere used.