COM functions should be in message send graph for application deployment#1237
Merged
COM functions should be in message send graph for application deployment#1237
Conversation
An Environment Browser open on an RBModel, e.g. to browse the content of a deployed application, throws DNUs when attempting to browse references to instance variables, protocols, and method categories.
Following recent changes to image deployment COM functions required by implementations of COM interfaces are being removed, with this breaking deployment of the Simple Web Browser example. This is because the defineFunctions methods are now being removed. The function tables need to be considered as sources of message sends, except where the interface is for egress only, i.e. unless only used for call out. By default all interfaces are considered potentially implementable, with an opt-in flag to mark those known to be egress only.
- In some cases newer interfaces being removed as classes unreferenced, so downcast not finding them. This results in some functionality not working, e.g. profiles. - Event handlers/completion handlers may require structure or interface argument types that were being removed as the interface functions were ungenerated. - The majority of the large number of interfaces are egress-only, so can be marked as such to reduce the size of the deployed application.
- XMLDOM - mostly, excluding SAX handlers - VBScript regex - all
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Following recent changes to image deployment COM functions required by implementations of COM interfaces are being removed, with this breaking deployment of the Simple Web Browser example. This is because the defineFunctions methods are now being removed. The function tables need to be considered as sources of message sends, except where the interface is
for egress only, i.e. unless only used for call out. By default all interfaces are considered potentially implementable, with an opt-in flag to mark those known to be egress only.
Fix a few other deployment issues with the Simple Web Browser sample, and upgrade to a more recent WebView2 SDK, although it has only minor changes.
Also iron out any issues deploying the XmlPad sample, which depends heavily on the MSXML COM component.