add forgotten shell=True to Popen#1
add forgotten shell=True to Popen#1yaniv-aknin wants to merge 1 commit intodoloopwhile:masterfrom yaniv-aknin:patch-1
Conversation
'command' is a shell builtin, and is not available as an external binary on all platforms; you must pass shell=True if you want it to work.
|
Thank you for your fixing. I merged it into my branch and PyPI |
|
Thanks! |
|
I'm sorry that I don't know any technical details as to why, but having shell=True breaks the "command" command for OS X. I'm not sure if there is a more system independent way to check for the existence of a JavaScript runtime, or if there would need to be some system detection logic to determine how to execute the "command" command. |
|
ugh. To be honest, I ran into further issues with finding runtimes, but didn't have time to author a clean fix and offer a pull request. I forked PyExecJs and did what local hacks I needed to get things going and left it as it is. If @doloopwhile (or anyone else) is interested in fixing this, I suggest implementing a pure-Python implementation of |
|
I took a stab at it... I tried it on Mac OS X and Ubuntu 11.10 and it seemed to work with Node.js installed for both. |
|
I pushed new commit. It includes a implementation pure Python "which" based on your idea. |
|
I really did very little, no sweat. |
'command' is a shell builtin, and is not available as an external binary on all platforms; you must pass shell=True if you want it to work.