Allow apps:destroy when not in a project#2270
Merged
michaelshobbs merged 3 commits intodokku:masterfrom Jun 26, 2016
Merged
Conversation
Member
|
How does heroku behave in this situation? This client is intended to mimic the official Heroku behaviors and so we should definitely do what they do here. |
Contributor
Author
Member
|
Does it end up leaving the remote in your git repo? |
Contributor
Author
Member
|
Ok I expect that behavior. Does it leave the remote in the repo if you delete the app from another directory? |
Contributor
Author
Member
|
Excellent! Let me get these tests running again and we'll get this merged. Thanks for contributing! |
Contributor
Author
|
@michaelshobbs thanks ! |
Member
|
Looks like there is a bug here. Though I'm not 100% certain why based on the diff. If you have time to debug that would be great otherwise I can look at it later. |
contrib/dokku_client.sh
Outdated
| ;; | ||
| apps:destroy) | ||
| git remote remove dokku | ||
| is_git_repo && has_dokku_remote && remote remove dokku |
Member
There was a problem hiding this comment.
This is missing the git part of the remote remove dokku call.
`git remote show <remote>` seems to really check if the remote is a git repo whereas we just want to know if a remote named "dokku" is present
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Previously, when not in a git project with a
dokkuremote,dokku apps:destroyfailed because ofgit remote remove dokkuerror status.