This repository was archived by the owner on Jul 30, 2018. It is now read-only.
Do not call schedule render every invalidate, only on setting properties and children #692
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type: bug
The following has been addressed in the PR:
Description:
Calling
scheduleRenderevery timeinvalidateis called is problematic in certain scenarios when a widget is wrapped by theProjectorMixin.widgethas a property registered with a custom diff that always returns changed as true i.e.diffProperty('my-prop', always)@alwaysRenderdecorator (such as theContainerHOC).Currently this causes
projectorinstances to continuously schedule a render, asthis.invalidate()will be called for all__setProperties__calls.Overriding
invalidatein this way should not be needed, as a listener that callsscheduleRenderis attached toprojectorinstances'invalidatedevent.Instead this
invalidatedevent can be explicitly emitted at the end ofsetPropertiesandsetChildren, the public API for projector instances.Other mechanisms such as
injectorsof external state that need to schedule a render, also emit aninvalidatedevent and therefore will be surescheduleRenderis fired.