Add support for externals #98
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Bradley Maier seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account. |
matt-gadd
requested changes
May 18, 2018
| new ExternalLoaderPlugin({ | ||
| dependencies: externalDependencies, | ||
| outputPath: args.externals && args.externals.outputPath, | ||
| pathPrefix: args.withTests ? '../_build/src' : '' |
Contributor
There was a problem hiding this comment.
is withTests a valid argument to cli-build-app? We just use the separate test conf when passed a mode of test now I think?
Contributor
There was a problem hiding this comment.
I don’t think the build commands use _build for anything so I’m not totally sure what this does either?
Contributor
|
fixed in #31 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.