Work around games sampling MSAA textures #4731
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
doitsujin
force-pushed
the
msaa-sampling
branch
2 times, most recently
from
48e722c to
1eb082e
Compare
doitsujin
force-pushed
the
msaa-sampling
branch
2 times, most recently
from
40e7451 to
e8856ea
Compare
doitsujin
force-pushed
the
msaa-sampling
branch
8 times, most recently
from
d6e384c to
7a16349
Compare
19 tasks
doitsujin
force-pushed
the
msaa-sampling
branch
3 times, most recently
from
023238e to
aedb837
Compare
Otherwise, if the app binds the same set of render targets again, the dirty framebuffer flag will get cleared.
Reduces pointer chasing.
Current AMDVLK has faster render pass resolves than what we can do with fmask, and our render pass resolve path can deal with all types of color images now if we pass the correct resolve mode. Keep the fb path for non-standard depth resolve modes as well as swapchain blits with composition, but otherwise there is no reason to use this path by default anymore.
Removes some code duplication while adding support for non-AVERAGE resolves for plain color images. Also nuke the AMD path since it is no longer used.
Elides redundant back-to-back resolves in some games, and reduces some barrier spam when the app resolves multiple images.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Huge pain in the arse, but this should fix striped patterns on Nvidia in a bunch of games that fuck up their MSAA usage.
TL;DR every Ubisoft game ever (and a bunch of others) try to bind a multisampled image as a plain
Texture2Dinstead of either resolving or usingTexture2DMSin the shader. This is light years deep into undefined behaviour territory, but happens to work on some native drivers. On AMD, this has trivially worked before with DXVK as well because the hardware samples from the first plane, but it's invalid Vulkan either way and made MSAA completely ineffective in a number of games that essentially draw the unresolved image to the swapchain (think World of Final Fantasy, #1216).Instead, we can do the right thing and just do an implicit
SAMPLE_ZEROresolve, which roughly matches what happens on AMD hardware anyway.