[d3d9] Add R16 and AL16 as known unsupported formats + some cleanup #4228
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WinterSnowfall
force-pushed
the
d3d9-formats
branch
from
2fcf49e to
df327d0
Compare
WinterSnowfall
force-pushed
the
d3d9-formats
branch
from
df327d0 to
9aee5a7
Compare
WinterSnowfall
force-pushed
the
d3d9-formats
branch
from
9aee5a7 to
0f116ac
Compare
Contributor
Author
|
After checks with both d3d8 and d3d9 on native Nvidia and AMD (thanks to @Blisto91), it looks like none of these formats are or were ever supported (thanks, WinXP), not even with CreateOffscreenPlainSurface and D3DPOOL_SCRATCH. So, I've only left the necessary entries for them not to generate log spam, since they're now proven to be red herrings that might mislead people into thinking we're not supporting something we should be (I too was once one of them, I should know :). Odd that WineD3D would support them, but following native behavior is of course the best option. Even stranger that a fair number of games from the era seem to attempt to employ them. |
K0bin
approved these changes
Sep 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some games will use these two formats (excessively even) with CreateOffscreenPlainSurface (d3d9) / CreateImageSurface (d3d8), which won't fail even for known unsupported formats. We've had the same problem with P8 on d3d8 side in the past.
WineD3D supports both R16 and AL16 along these lines, but not with CreateTexture (nor does it advertise them as supported formats). This PR brings us on par and is also meant to silence a lot of
ConvertFormat: Unknown format encounteredwarnings we've seen in logs for these two formats in particular.I've also cleaned up some supported formats from GetUnsupportedFormatInfo, for good measure (I'm assuming nobody bothered to remove them from there once support was added).
Draft for now as I still have to: