[d3d8] Implement Dref scaling and fixed-function depth textures #3565
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Windows builds failed due to 404 for Vulkan SDK. This PR should compile fine on MSVC. |
|
The Windows build error is known and have been fixed with this PR #3556 |
13 tasks
doitsujin
reviewed
Jun 10, 2024
| // bind depth textures to fixed function shaders. | ||
| if (m_dxsoOptions.drefScaling) | ||
| stage.SampleDref = (m_depthTextures & (1 << idx)) != 0; | ||
| stage.SampleDref = (m_depthTextures & (1 << idx)) != 0; |
There was a problem hiding this comment.
is there a reason why this is a separate commit and not just done by default?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #3411, but not a requirement for #3411 to merge.
More info:
Simplified from #3536 since we probably don't need additional shadow filtering based on videos I can find of period hardware. Only dgVoodoo2 does extra shadow filtering as far as I'm aware.