[util] Allow switching log file at runtime #3516
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
13 tasks
|
Is there a reason to static link d3d9? |
|
I do not really see the point in overcomplicating this, let's just dynamically link and keep the log files the same. |
|
@Joshua-Ashton Dynamically linking caused a lot of crashing on load issues on Windows. Not entirely sure why, but Windows compatibility drastically increased when d8vk switched to static linking. Maybe it's something we need to look deeper into. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #3411
Required since d3d8 is a single DLL, but links d3d9 as a static library, so we need a way to override the initialization-time log filename.