feat: specify product types for Stripe migration - #9

src/providers/stripe/index.ts (2)

138-195: Deduplicate product type to avoid drift between wrapper and payload

You’re now storing the product type twice: wrapper type and data.type. Reduce risk by deriving both from a single variable.

Apply this diff:

@@
-            for (const price of prices.data) {
-                const isRecurring = price.type === 'recurring';
+            for (const price of prices.data) {
+                const isRecurring = price.type === 'recurring';
+                const productType: 'subscription_product' | 'one_time_product' =
+                  isRecurring ? 'subscription_product' : 'one_time_product';
@@
-                    ProductsToMigrate.push({
-                        type: 'subscription_product',
+                    ProductsToMigrate.push({
+                        type: productType,
                         data: {
@@
-                            tax_category: 'saas',
-                            type: 'subscription_product',
+                            tax_category: 'saas',
+                            type: productType,
@@
-                    ProductsToMigrate.push({
-                        type: 'one_time_product',
+                    ProductsToMigrate.push({
+                        type: productType,
                         data: {
@@
-                            tax_category: 'saas',
-                            type: 'one_time_product',
+                            tax_category: 'saas',
+                            type: productType,

---

138-139: Strongly type the payload (avoid any)

Replace data: any with a typed payload to catch enum/value regressions at compile time. If the SDK exports a create‑product type, import it; otherwise declare a minimal local interface.

Would you like me to add a local type like below if the SDK doesn’t export one?

type DodoProductType = 'one_time_product' | 'subscription_product';
type DodoPriceType = 'one_time_price' | 'recurring_price';

interface DodoProductPricePayload {
  currency: string;
  price: number;
  discount: number;
  purchasing_power_parity: boolean;
  type: DodoPriceType;
  billing_period?: 'monthly' | 'yearly';
}

interface DodoProductCreatePayload {
  name: string;
  description?: string;
  tax_category: string;
  type: DodoProductType;
  price: DodoProductPricePayload;
  brand_id: string;
}

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro