feat: Add Coupons Migration to Lemon Squeezy Provider - #7

docs/stripe/README.md (1)

3-6: Fix Markdown heading and fenced block formatting

markdownlint is flagging the #### Usage: heading jump and the unlabeled code fence right below it. Bumping the heading to ## and tagging the snippet as bash resolves both issues without changing meaning.

-#### Usage:
-```
-dodo-migrate stripe
-```
+## Usage
+```bash
+dodo-migrate stripe
+```

README.md (1)

57-66: Add fenced code languages to satisfy markdownlint (MD040).

Mark the CLI snippets as console/bash for readability and lint compliance.

Apply:

-```
+```console
 dodo-migrate lemonsqueezy

- +console
dodo-migrate stripe

...
-```
+```bash
dodo-migrate lemonsqueezy \
  --provider-api-key=lsq_XXXXXXXXXXXXXXXX \
  --dodo-api-key=dp_XXXXXXXXXXXXXXXX \
  --mode=test_mode \
  --dodo-brand-id=brand_XXXXXX

- +bash
dodo-migrate stripe
--provider-api-key=sk_test_XXXXXXXXXXXXXXXX
--dodo-api-key=dp_XXXXXXXXXXXXXXXX
--mode=test_mode
--dodo-brand-id=brand_XXXXXX
--migrate-types=products,coupons

Also applies to: 100-104, 106-119

src/providers/stripe/index.ts (4)

169-171: Subscription cadence mapping is incomplete.

Interval_count (e.g., every 3 months) and weekly/daily intervals are not handled and default to monthly, potentially wrong in target.

Would you like me to add an interval mapper (handles day/week/month/year + interval_count) and confirm what Dodo accepts for billing_period? Based on learnings.

---

209-215: Rename local variable to avoid shadowing the function name.

Improves readability.

Apply:

-        const migrateProducts = await select({
+        const proceedProducts = await select({
             message: 'Proceed to create these products in Dodo Payments?',
             choices: [
                 { name: 'Yes', value: 'yes' },
                 { name: 'No', value: 'no' }
             ],
         });
 
-        if (migrateProducts === 'yes') {
+        if (proceedProducts === 'yes') {

Also applies to: 217-230

---

299-305: Rename local variable to avoid shadowing the function name.

Apply:

-        const migrateCoupons = await select({
+        const proceedCoupons = await select({
             message: 'Proceed to create these coupons in Dodo Payments?',
             choices: [
                 { name: 'Yes', value: 'yes' },
                 { name: 'No', value: 'no' }
             ],
         });
 
-        if (migrateCoupons === 'yes') {
+        if (proceedCoupons === 'yes') {

Also applies to: 307-321

---

380-386: Rename local variable to avoid shadowing the function name.

Apply:

-        const migrateCustomers = await select({
+        const proceedCustomers = await select({
             message: 'Proceed to create these customers in Dodo Payments?',
             choices: [
                 { name: 'Yes', value: 'yes' },
                 { name: 'No', value: 'no' }
             ],
         });
 
-        if (migrateCustomers === 'yes') {
+        if (proceedCustomers === 'yes') {

Also applies to: 388-402

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

src/providers/stripe/index.ts (2)

276-281: Promotion codes: add active filter and paginate; otherwise you’ll miss >100 and include disabled codes.

Use active: true and autoPagingEach (or autoPagingToArray) to iterate all promotion codes.

-// Fetch promotion codes for this coupon
-const promotionCodes = await stripe.promotionCodes.list({
-  coupon: coupon.id,
-  limit: 100
-});
+// Fetch all active promotion codes for this coupon
+const promoCodes: Stripe.PromotionCode[] = [];
+await stripe.promotionCodes
+  .list({ coupon: coupon.id, active: true, limit: 100 })
+  .autoPagingEach((pc) => { promoCodes.push(pc); });

And replace subsequent uses of promotionCodes.data with promoCodes.

---

312-341: Use promotion code–specific fields (expires_at, max_redemptions, name) when mapping; don’t reuse coupon-level values.

For each promotion code: prefer promotionCode.expires_at and promotionCode.max_redemptions, and default name to coupon.name || promotionCode.code.

- for (const promotionCode of promotionCodes.data) {
+ for (const promotionCode of promoCodes) {
   // ... discountType/discountValue derived from coupon (unchanged)
-  const currency = coupon.amount_off ? coupon.currency?.toUpperCase() : undefined;
+  const currency = coupon.amount_off ? coupon.currency?.toUpperCase() : undefined;

   CouponsToMigrate.push({
-    code: promotionCode.code,
-    name: coupon.name || coupon.id,
+    code: promotionCode.code,
+    name: coupon.name || promotionCode.code,
     discount_type: discountType,
     amount: discountValue,
     currency: currency,
-    usage_limit: coupon.max_redemptions || null,
-    expires_at: coupon.redeem_by ? new Date(coupon.redeem_by * 1000).toISOString() : null,
+    usage_limit: promotionCode.max_redemptions ?? null,
+    expires_at: promotionCode.expires_at
+      ? new Date(promotionCode.expires_at * 1000).toISOString()
+      : null,
     brand_id: brand_id
   });
 }

src/providers/lemonsqueezy/index.ts (4)

35-39: Add validation for the --types option.

The --types option currently accepts any comma-separated string without validation. If a user provides invalid types (e.g., --types=foo,bar), the script will run but migrate nothing, which may confuse users.

Consider validating the types after parsing in the handler:

// After line 67, add validation
if (migrationTypes.length === 0) {
    console.log('[ERROR] No migration types selected. Please select at least one type.');
    process.exit(1);
}

const validTypes = ['products', 'coupons'];
const invalidTypes = migrationTypes.filter(type => !validTypes.includes(type));
if (invalidTypes.length > 0) {
    console.log(`[ERROR] Invalid migration types: ${invalidTypes.join(', ')}. Valid types are: ${validTypes.join(', ')}`);
    process.exit(1);
}

---

296-308: Enhance error handling for failed coupon migrations.

The current error handling stringifies the entire error object, which may not provide clear information to users. If a coupon fails due to validation errors (e.g., missing currency, duplicate code, invalid format), users would benefit from more specific error messages.

Consider parsing and displaying structured error information:

                         } catch (error) {
-                            console.log(`[ERROR] Failed to migrate coupon: ${coupon.data.name} - ${error}`);
+                            console.log(`[ERROR] Failed to migrate coupon: ${coupon.data.name}`);
+                            if (error && typeof error === 'object' && 'message' in error) {
+                                console.log(`[ERROR] Reason: ${error.message}`);
+                            } else {
+                                console.log(`[ERROR] Reason: ${error}`);
+                            }
                             failureCount++;
                         }

---

166-166: Address type assertions for currency fields.

Multiple as any type assertions are used when assigning currency values from Lemon Squeezy to Dodo Payments (Lines 166, 238, 252). These assertions bypass TypeScript's type safety and may hide actual type incompatibilities between the two APIs.

Investigate the actual types returned by the Lemon Squeezy SDK and expected by Dodo Payments. Consider:

1. Creating a type mapping function if the currency formats differ
2. Adding runtime validation to ensure currency values are valid
3. Using proper type assertions with validation rather than as any

Example approach:

type LemonSqueezyCurrency = string; // actual type from SDK
type DodoPaymentsCurrency = string; // actual type from Dodo API

function mapCurrency(lsCurrency: LemonSqueezyurrency | undefined): DodoPaymentsCurrency | undefined {
    // Add validation/mapping logic if needed
    return lsCurrency;
}

// Usage
currency: mapCurrency(StoreData.data.attributes.currency)

Also applies to: 238-238, 252-252

---

236-254: Remove the unnecessary initial check for discount.attributes.currency — the Lemon Squeezy API does not return a currency field on discount objects.

The Lemon Squeezy Discount object does not include a currency field. The code at line 238 using (discount as any).attributes.currency will always be undefined, making the initial check dead code. Fixed amounts are stored as cents and currency is implied by the store/order, so the store data fallback (lines 240–253) will always be needed.

Simplify by removing the unnecessary type assertion and initial check:

                let fixedCurrency: string | undefined = undefined;
                if (discount.attributes.amount_type === 'fixed') {
-                    fixedCurrency = (discount as any).attributes.currency;
-                    if (!fixedCurrency) {
                         // Fallback: use cached store currency or fetch and cache the store if not present
                         if (!StoresData[discount.attributes.store_id]) {
                             // ... fetch store
                         }
                         fixedCurrency = StoresData[discount.attributes.store_id]?.data.attributes.currency as any;
-                    }
                 }

src/providers/stripe/index.ts (1)

161-167: unit_amount guard is good; drop fallback “|| 0” to avoid masking issues.

You already skip null amounts; prefer using the non-null value directly to prevent accidental zeros.

- price: price.unit_amount || 0,
+ price: price.unit_amount as number,

Apply to both one-time and recurring blocks.

Also applies to: 176-177, 196-197

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

src/providers/lemonsqueezy/index.ts (3)

1-1: Remove unused import.

getProduct is imported but never referenced in the code.

Apply this diff:

-import { listProducts, lemonSqueezySetup, getProduct, getStore, Store, listDiscounts } from '@lemonsqueezy/lemonsqueezy.js';
+import { listProducts, lemonSqueezySetup, getStore, Store, listDiscounts } from '@lemonsqueezy/lemonsqueezy.js';

---

235-254: Currency resolution logic is solid.

The fallback to store currency when discount.attributes.currency is unavailable ensures fixed-amount coupons always have currency defined. The caching prevents redundant API calls.

Consider removing the type assertion on Line 238 for better type safety:

-                    fixedCurrency = (discount as any).attributes.currency;
+                    fixedCurrency = discount.attributes.currency;

If TypeScript complains, verify the @lemonsqueezy/lemonsqueezy.js types include currency on discount attributes for fixed amounts, or add a proper type guard.

---

259-260: Clarify the normalization comment.

The comment implies all amounts are multiplied by 100, but only percentage discounts are transformed (to basis points for Dodo). Fixed amounts remain in minor units.

Apply this diff:

-                    // * 100 to normalize it to Dodo Payments expected format
-                    amount: discount.attributes.amount_type === 'percent' ? discount.attributes.amount * 100 : discount.attributes.amount,
+                    // For percentage: convert to basis points (e.g., 10% → 1000). For fixed: keep minor units as-is.
+                    amount: discount.attributes.amount_type === 'percent' ? discount.attributes.amount * 100 : discount.attributes.amount,

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

src/providers/lemonsqueezy/index.ts (1)

1-1: Remove unused getProduct import.

The getProduct function is imported but never used in the code.

Apply this diff:

-import { listProducts, lemonSqueezySetup, getProduct, getStore, Store, listDiscounts } from '@lemonsqueezy/lemonsqueezy.js';
+import { listProducts, lemonSqueezySetup, getStore, Store, listDiscounts } from '@lemonsqueezy/lemonsqueezy.js';

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro