-
Notifications
You must be signed in to change notification settings - Fork 2.5k
Deprecate FieldMapping::$default #12273
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Its purpose is unclear since there is FieldMapping::$options['default'] already.
|
I don't think supporting I don't think this deprecation makes sense. I would rather deprecate passing options for option names that are handled by SchemaTool based on the field mapping. |
Maybe not today, but in the past, that seemed to be the only way to do it: https://stackoverflow.com/a/53224518/353612 Also, notice how the Lines 11 to 37 in f18de9d
Are you suggesting that people should not refer to the new DBAL value objects in their mappings?
I don't really understand what that means… can you please elaborate? Are you maybe talking about these: Line 68 in f18de9d
In any case, I could not find documentation on this feature. I think that usually default values are derived from the default value of the property, which might explain the lack of docs. However for |
|
oh, I was not aware that FieldMapping had this |
Its purpose is unclear since there is
FieldMapping::$options['default']already.