Add a CI job that fails on deprecations #12188
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
derrabus
force-pushed
the
improvement/fail-on-deprecations
branch
from
1eeea2b to
3ccfff4
Compare
Member
Author
Member
|
if I don't miss anything there is one additional warning compared to what would be fixed with #12160/#12181: |
Member
|
merging the changes from #12182 into upper branches will also resolve two of the reported deprecations |
greg0ire
reviewed
Oct 7, 2025
greg0ire
approved these changes
Oct 7, 2025
derrabus
force-pushed
the
improvement/fail-on-deprecations
branch
from
3ccfff4 to
a02f037
Compare
Member
Author
|
I've merged up @xabbuh's changes and rebased my PR on top of them. |
derrabus
added a commit
to derrabus/orm
that referenced
this pull request
Oct 7, 2025
* 3.5.x: Add a CI job that fails on deprecations (doctrine#12188) use the empty string instead of null as an array offset (doctrine#12181) do not call setAccessible() on PHP >= 8.1 (doctrine#12182) Fix docs on final entities (doctrine#12176) Remove Database and Model First chapters that said little of value. Switch to IgnoreDeprecations docs: consistent PostgreSQL's name case docs: generation strategies differences between DBAL 3 and 4 Check extra condition to decide if a test was skipped Use PHPUnit 11 when possible Migrate away from annotations in tests Migrate away from assertStringNotMatchesFormat() Migrate to willReturn() Migrate away from getMockForAbstractClass() Fix `IN`/`NOT IN` expression handling and support enums when matching on to-many-collections
derrabus
added a commit
to derrabus/orm
that referenced
this pull request
Oct 7, 2025
* 3.6.x: Add a CI job that fails on deprecations (doctrine#12188) use the empty string instead of null as an array offset (doctrine#12181) do not call setAccessible() on PHP >= 8.1 (doctrine#12182) Fix docs on final entities (doctrine#12176) Remove Database and Model First chapters that said little of value. Switch to IgnoreDeprecations Fix php doc for getPropertyAccessors method (doctrine#12159) docs: consistent PostgreSQL's name case docs: generation strategies differences between DBAL 3 and 4 Check extra condition to decide if a test was skipped Use PHPUnit 11 when possible Migrate away from annotations in tests Migrate away from assertStringNotMatchesFormat() Migrate to willReturn() Migrate away from getMockForAbstractClass() Fix `IN`/`NOT IN` expression handling and support enums when matching on to-many-collections
derrabus
added a commit
to derrabus/orm
that referenced
this pull request
Oct 8, 2025
* 3.6.x: Fix missing import Remove calls to getMockForAbstractClass() (doctrine#12003) Add a CI job that fails on deprecations (doctrine#12188) use the empty string instead of null as an array offset (doctrine#12181) Upgrade to doctrine/coding-standard 14 Bump doctrine/.github from 7.3.0 to 8.0.0 do not call setAccessible() on PHP >= 8.1 (doctrine#12182) Fix docs on final entities (doctrine#12176) Remove Database and Model First chapters that said little of value. Switch to IgnoreDeprecations Fix php doc for getPropertyAccessors method (doctrine#12159) docs: consistent PostgreSQL's name case docs: generation strategies differences between DBAL 3 and 4 Check extra condition to decide if a test was skipped Use PHPUnit 11 when possible Migrate away from annotations in tests Migrate away from assertStringNotMatchesFormat() Migrate to willReturn() Migrate away from getMockForAbstractClass() Fix `IN`/`NOT IN` expression handling and support enums when matching on to-many-collections
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We want to be notified early about runtime deprecations. This is why I'm adding a job that fails if deprecations are being triggered during the execution of the PHPUnit test suite.