Skip to content

Create ReflectionReadonlyProperty from their declaring class so their value can be set #10666

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
greg0ire merged 4 commits into from
May 12, 2023
Merged

Create ReflectionReadonlyProperty from their declaring class so their value can be set #10666

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
721794f
Add test case
MatTheCat May 7, 2023
c7c57be
Create `ReflectionReadonlyProperty` from their declaring class so the…
MatTheCat May 1, 2023
a3fa1d7
Replace assertions by @doesNotPerformAssertions
MatTheCat May 7, 2023
2f46e5a
Rename test class and method
MatTheCat May 11, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion lib/Doctrine/ORM/Mapping/ClassMetadataInfo.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3862,7 +3862,14 @@ private function getAccessibleProperty(ReflectionService $reflService, string $c
{
$reflectionProperty = $reflService->getAccessibleProperty($class, $field);
if ($reflectionProperty !== null && PHP_VERSION_ID >= 80100 && $reflectionProperty->isReadOnly()) {
$reflectionProperty = new ReflectionReadonlyProperty($reflectionProperty);
$declaringClass = $reflectionProperty->getDeclaringClass()->name;
if ($declaringClass !== $class) {
$reflectionProperty = $reflService->getAccessibleProperty($declaringClass, $field);
}

if ($reflectionProperty !== null) {
$reflectionProperty = new ReflectionReadonlyProperty($reflectionProperty);
}
}

return $reflectionProperty;
Expand Down
36 changes: 36 additions & 0 deletions tests/Doctrine/Tests/ORM/Functional/Ticket/GH10049/GH10049Test.php
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,36 @@
<?php

declare(strict_types=1);

namespace Doctrine\Tests\ORM\Functional\Ticket\GH10049;

use Doctrine\Tests\OrmFunctionalTestCase;

/**
* @requires PHP 8.1
*/
class GH10049Test extends OrmFunctionalTestCase
{
public function setUp(): void
{
parent::setUp();

$this->createSchemaForModels(
ReadOnlyPropertyOwner::class,
ReadOnlyPropertyInheritor::class
);
}

/**
* @doesNotPerformAssertions
*/
public function testInheritedReadOnlyPropertyValueCanBeSet(): void
{
$child = new ReadOnlyPropertyInheritor(10049);
$this->_em->persist($child);
$this->_em->flush();
$this->_em->clear();

$this->_em->find(ReadOnlyPropertyInheritor::class, 10049);
}
}
14 changes: 14 additions & 0 deletions tests/Doctrine/Tests/ORM/Functional/Ticket/GH10049/ReadOnlyPropertyInheritor.php
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,14 @@
<?php

declare(strict_types=1);

namespace Doctrine\Tests\ORM\Functional\Ticket\GH10049;

use Doctrine\ORM\Mapping as ORM;

/**
* @ORM\Entity
*/
class ReadOnlyPropertyInheritor extends ReadOnlyPropertyOwner
{
}
22 changes: 22 additions & 0 deletions tests/Doctrine/Tests/ORM/Functional/Ticket/GH10049/ReadOnlyPropertyOwner.php
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,22 @@
<?php

declare(strict_types=1);

namespace Doctrine\Tests\ORM\Functional\Ticket\GH10049;

use Doctrine\ORM\Mapping as ORM;

/**
* @ORM\MappedSuperclass
*/
abstract class ReadOnlyPropertyOwner
{
public function __construct(
/**
* @ORM\Id
* @ORM\Column(type="integer")
*/
public readonly int $id
) {
}
}