Skip to content

Comments

Hide sensitive parameters in PDOConnect::doConnect()#7214

Merged
derrabus merged 2 commits intodoctrine:3.10.xfrom
dmitryuk:sensitive
Nov 23, 2025
Merged

Hide sensitive parameters in PDOConnect::doConnect()#7214
derrabus merged 2 commits intodoctrine:3.10.xfrom
dmitryuk:sensitive

Conversation

@dmitryuk
Copy link
Contributor

@dmitryuk dmitryuk commented Nov 17, 2025

Q A
Type improvement
Fixed issues

Summary

If error is triggered while reconnect it will log a message with opened dsn and password.
The PR mark these fields as Sensitive

image

@dmitryuk dmitryuk changed the title PDOConnect::doConnect sensitive parameters PDOConnect::doConnect hide sensitive parameters Nov 17, 2025
@greg0ire
Copy link
Member

@dmitryuk would it make sense to contribute this to 3.10?

@dmitryuk
Copy link
Contributor Author

@greg0ire
I think it can, should I reopen MR to 3.10 target branch?

@greg0ire
Copy link
Member

@dmitryuk dmitryuk changed the base branch from 4.3.x to 3.10.x November 23, 2025 08:57
@dmitryuk
Copy link
Contributor Author

@greg0ire, done

@derrabus derrabus closed this Nov 23, 2025
@derrabus derrabus reopened this Nov 23, 2025
@derrabus derrabus added the Bug label Nov 23, 2025
@derrabus derrabus added this to the 3.10.4 milestone Nov 23, 2025
@derrabus derrabus merged commit 306efa9 into doctrine:3.10.x Nov 23, 2025
61 checks passed
@derrabus derrabus changed the title PDOConnect::doConnect hide sensitive parameters Hide sensitive parameters in PDOConnect::doConnect() Nov 23, 2025
derrabus added a commit to derrabus/dbal that referenced this pull request Nov 23, 2025
* 3.10.x:
  Remove fail fast
  Run CI on PHP 8.5 (doctrine#7219)
  PDOConnect::doConnect hide sensitive parameters (doctrine#7214)
derrabus added a commit to derrabus/dbal that referenced this pull request Nov 23, 2025
* 4.3.x:
  Remove fail fast
  Run CI on PHP 8.5 (doctrine#7219)
  PDOConnect::doConnect hide sensitive parameters (doctrine#7214)
derrabus added a commit to derrabus/dbal that referenced this pull request Nov 29, 2025
* 4.4.x:
  Bump GitHub actions (doctrine#7229)
  Test against stable Symfony 8 (doctrine#7228)
  Bump doctrine/.github/.github/workflows/phpstan.yml from 12.2.0 to 13.0.0 (doctrine#7223)
  Bump doctrine/.github/.github/workflows/documentation.yml from 12.2.0 to 13.0.0 (doctrine#7224)
  Bump doctrine/.github/.github/workflows/coding-standards.yml from 12.2.0 to 13.0.0 (doctrine#7225)
  Bump actions/checkout from 5 to 6
  Remove fail fast
  Run CI on PHP 8.5 (doctrine#7219)
  PDOConnect::doConnect hide sensitive parameters (doctrine#7214)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants