Hide sensitive parameters in PDOConnect::doConnect()#7214
Merged
derrabus merged 2 commits intodoctrine:3.10.xfrom Nov 23, 2025
Merged
Hide sensitive parameters in PDOConnect::doConnect()#7214derrabus merged 2 commits intodoctrine:3.10.xfrom
PDOConnect::doConnect()#7214derrabus merged 2 commits intodoctrine:3.10.xfrom
Conversation
Member
|
@dmitryuk would it make sense to contribute this to 3.10? |
Contributor
Author
|
@greg0ire |
Member
|
You don't need to; you can just: |
Contributor
Author
|
@greg0ire, done |
derrabus
approved these changes
Nov 23, 2025
PDOConnect::doConnect()
derrabus
added a commit
to derrabus/dbal
that referenced
this pull request
Nov 23, 2025
* 3.10.x: Remove fail fast Run CI on PHP 8.5 (doctrine#7219) PDOConnect::doConnect hide sensitive parameters (doctrine#7214)
derrabus
added a commit
to derrabus/dbal
that referenced
this pull request
Nov 23, 2025
* 4.3.x: Remove fail fast Run CI on PHP 8.5 (doctrine#7219) PDOConnect::doConnect hide sensitive parameters (doctrine#7214)
derrabus
added a commit
to derrabus/dbal
that referenced
this pull request
Nov 29, 2025
* 4.4.x: Bump GitHub actions (doctrine#7229) Test against stable Symfony 8 (doctrine#7228) Bump doctrine/.github/.github/workflows/phpstan.yml from 12.2.0 to 13.0.0 (doctrine#7223) Bump doctrine/.github/.github/workflows/documentation.yml from 12.2.0 to 13.0.0 (doctrine#7224) Bump doctrine/.github/.github/workflows/coding-standards.yml from 12.2.0 to 13.0.0 (doctrine#7225) Bump actions/checkout from 5 to 6 Remove fail fast Run CI on PHP 8.5 (doctrine#7219) PDOConnect::doConnect hide sensitive parameters (doctrine#7214)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
If error is triggered while reconnect it will log a message with opened dsn and password.
The PR mark these fields as Sensitive