Introduce DefaultExpression #7195
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Ah that's too bad 😛 |
greg0ire
approved these changes
Oct 13, 2025
Member
Author
Fixed 🫣 |
greg0ire
added a commit
to greg0ire/doctrine-orm
that referenced
this pull request
Nov 9, 2025
This addresses the deprecation introduced in doctrine/dbal#7195 A follow-up should be to deprecate not using these value objects in field mappings, so that we do not just reproduce the same checks that the DBAL wants to remove.
greg0ire
added a commit
to greg0ire/doctrine-orm
that referenced
this pull request
Nov 9, 2025
This addresses the deprecation introduced in doctrine/dbal#7195 A follow-up should be to deprecate not using these value objects in field mappings, so that we do not just reproduce the same checks that the DBAL wants to remove.
greg0ire
added a commit
to greg0ire/doctrine-orm
that referenced
this pull request
Nov 9, 2025
This addresses the deprecation introduced in doctrine/dbal#7195 A follow-up should be to deprecate not using these value objects in field mappings, so that we do not just reproduce the same checks that the DBAL wants to remove.
greg0ire
added a commit
to greg0ire/doctrine-orm
that referenced
this pull request
Nov 9, 2025
This addresses the deprecation introduced in doctrine/dbal#7195 A follow-up should be to deprecate not using these value objects in field mappings, so that we do not just reproduce the same checks that the DBAL wants to remove.
greg0ire
added a commit
to greg0ire/doctrine-orm
that referenced
this pull request
Nov 9, 2025
This addresses the deprecation introduced in doctrine/dbal#7195 A follow-up should be to deprecate not using these value objects in field mappings, so that we do not just reproduce the same checks that the DBAL wants to remove.
greg0ire
added a commit
to greg0ire/doctrine-orm
that referenced
this pull request
Nov 10, 2025
This addresses the deprecation introduced in doctrine/dbal#7195 A follow-up should be to deprecate not using these value objects in field mappings, so that we do not just reproduce the same checks that the DBAL wants to remove.
greg0ire
added a commit
to greg0ire/doctrine-orm
that referenced
this pull request
Nov 10, 2025
This addresses the deprecation introduced in doctrine/dbal#7195 A follow-up should be to deprecate not using these value objects in field mappings, so that we do not just reproduce the same checks that the DBAL wants to remove.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a prerequisite for fixing #7194.
DefaultExpressioncan be used to represent column default expressions in a portable way. Subsequently, we can use the same interface to represent literal expressions (strings, numbers, etc.).Backward compatibility
In theory, using objects instead of strings may impact schema comparison: the column definition obtained via schema introspection will still contain a string representing the default expression, not the
DefaultExpressionobject. In practice, it shouldn’t be a problem because column definitions are compared as their DDL:dbal/src/Platforms/AbstractPlatform.php
Lines 2417 to 2422 in 42e278e