Remove driver unit test boilerplate#7178
Merged
morozov merged 1 commit intodoctrine:4.3.xfrom Oct 8, 2025
Merged
Conversation
derrabus
approved these changes
Oct 8, 2025
greg0ire
approved these changes
Oct 8, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This boilerplate doesn't seem to provide any value. Specifically:
createSchemaManager()is not called from anywhere, so it can be removed.createPlatform()is called only fromcreateSchemaManager(), so now it can be removed as well.createExceptionConverter()is only used bytestReturnsExceptionConverter(), which basically asserts that the library code is the same as the test code. This is pointless, so both these methods can be removed.Abstract<Some>DriverTestCaseclasses become empty, can be removed in favor of the concrete driver test case classes extending theAbstractDriverTestCaseclass directly.testReturnsExceptionConverter()which they inherited fromAbstractDriverTestCase.