Reorganize SQLitePlatform comment methods#7172
Merged
morozov merged 1 commit intodoctrine:4.4.xfrom Oct 7, 2025
Merged
Conversation
morozov
changed the title
The affected SQLite platform methods are a bit convoluted: 1. The private method `getInlineTableCommentSQL()` delegates to `getInlineColumnCommentSQL()` just because their implementations are identical. However, tables and columns are different database objects. 2. `getInlineTableCommentSQL()` is a one-liner invoked from a single place, so there is no point in declaring it as a separate method to begin with. Instead, now the implementation method is private and is name `getInlineCommentSQL()` (agnostic of the object type). It is is invoked from the table- and column-related methods.
morozov
force-pushed
the
sqlite-reorg-comment-methods
branch
from
4be14b0 to
7a96f6c
Compare
greg0ire
approved these changes
Oct 7, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The affected SQLite platform methods are a bit convoluted:
getInlineTableCommentSQL()delegates togetInlineColumnCommentSQL()just because their implementations are identical. However, tables and columns are different database objects.getInlineTableCommentSQL()is a one-liner invoked from a single place, so there is no point in declaring it as a separate method to begin with.Instead, now the implementation method is private and is name
getInlineCommentSQL()(agnostic of the object type). It is is invoked from the table- and column-related methods.