Make options check strict again#7141
Merged
derrabus merged 1 commit intodoctrine:4.3.xfrom Sep 4, 2025
Merged
Conversation
derrabus
added a commit
that referenced
this pull request
Sep 4, 2025
* 4.3.x: Make options check strict again Make options check strict again (#7141)
derrabus
added a commit
to derrabus/dbal
that referenced
this pull request
Sep 4, 2025
* 4.4.x: Make options check strict again Make options check strict again (doctrine#7141) Remove obsolete upgrade note (doctrine#7138) Document the PDO subclasses backport (doctrine#7137) Downgrade PHP for the DB2 workflow (doctrine#7134) Workaround for MySQL 8.4 and unknown users (doctrine#7136) Leverage PHP 8.4 PDO classes, fix PHP 8.5 deprecation (doctrine#7132) Run tests on MySQL 8.4 LTS and 9.4 (doctrine#7133)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
While merging up the changes from #7132, I noticed that the new code is in fact a little less strict than the old one. Previously, we required the
PDO::PGSQL_ATTR_DISABLE_PREPARESoption to be set totruewhile after the change we would accept any truthy value. I don't think that it's a big deal, but I also believe that this change was not intended. Thus, I'm restoring the old behavior.