Deprecate using keys of table-scoped object collections as names#7102
Merged
morozov merged 1 commit intodoctrine:4.4.xfrom Aug 26, 2025
Merged
Deprecate using keys of table-scoped object collections as names#7102morozov merged 1 commit intodoctrine:4.4.xfrom
morozov merged 1 commit intodoctrine:4.4.xfrom
Conversation
greg0ire
approved these changes
Aug 26, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The array returned by
Table::getColumns()doesn't contain column names as keys since #3583 (4.0.0). This PR deprecates using keys as names in other collections.Keys as lower-case names is the source of various issues:
Besides the deprecation, this PR reworks that code that would use the keys as names such that the keys are used only as pointers to elements in the collection, but without any specific meaning.