Implement IteratorAggregate in ObjectSet subclasses#7101
Merged
morozov merged 2 commits intodoctrine:4.4.xfrom Aug 24, 2025
Merged
Implement IteratorAggregate in ObjectSet subclasses#7101morozov merged 2 commits intodoctrine:4.4.xfrom
morozov merged 2 commits intodoctrine:4.4.xfrom
Conversation
derrabus
reviewed
Aug 23, 2025
Member
derrabus
left a comment
derrabus
left a comment
There was a problem hiding this comment.
Do we still need the toList() method then?
| /** {@inheritDoc} */ | ||
| public function getIterator(): Traversable | ||
| { | ||
| return new ArrayIterator($this->elements); |
Member
There was a problem hiding this comment.
Using a generator might be a bit more lightweight.
Suggested change
| return new ArrayIterator($this->elements); | |
| yield from $this->elements; |
| /** {@inheritDoc} */ | ||
| public function getIterator(): Traversable | ||
| { | ||
| return new ArrayIterator(array_values($this->elements)); |
Member
There was a problem hiding this comment.
Suggested change
| return new ArrayIterator(array_values($this->elements)); | |
| foreach ($this->elements as $element) { | |
| yield $element; | |
| } |
Member
Author
Yes, we still use it in some places. E.g. dbal/src/Schema/TableEditor.php Lines 542 to 547 in 413d5e2 |
morozov
force-pushed
the
object-set-as-traversable
branch
from
edcce80 to
3856e70
Compare
morozov
force-pushed
the
object-set-as-traversable
branch
from
3856e70 to
d739bd8
Compare
Member
|
Makes sense. |
derrabus
approved these changes
Aug 24, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Object sets may need to be iterated, but right now this is done by converting them to a list. This can be avoided if the set itself is made traversable.
This change is backward compatible, since since the
ObjectSetinterface being extended is@internal.