Allow support for JSON arrays within annotations #122
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ocramius
suggested changes
Feb 17, 2017
Member
Ocramius
left a comment
Ocramius
left a comment
There was a problem hiding this comment.
Code looks good, but we need to improve the testing of nested values, optional additional values.
This should be done both in the parser tests, and in the annotation reader afterwards, in my opinion.
@guilhermeblanco any opinion on supporting this?
| array('array', '{@AnnotationExtendsAnnotationTargetAll}'), | ||
| array('array', '{@AnnotationExtendsAnnotationTargetAll,@AnnotationExtendsAnnotationTargetAll}'), | ||
| array('array', '[@AnnotationExtendsAnnotationTargetAll]'), | ||
| array('array', '[@AnnotationExtendsAnnotationTargetAll,@AnnotationExtendsAnnotationTargetAll]'), |
Member
There was a problem hiding this comment.
Would need a few tests around parsing array elements, their order, and different types of sub-elements
| const T_TRUE = 110; | ||
| const T_NULL = 111; | ||
| const T_COLON = 112; | ||
| const T_OPEN_SQR_BRACKETS = 113; |
| const T_NULL = 111; | ||
| const T_COLON = 112; | ||
| const T_OPEN_SQR_BRACKETS = 113; | ||
| const T_CLOSE_SQR_BRACKETS = 114; |
Contributor
|
This is something that should be relatively easy with the new parser in Annotations 2.0. Milestoning, since there is no relevant issue, but it will require different implementation. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As said, added square brackets to complete support for JSON.