Skip to content

Conversation

@GromNaN
Copy link
Member

@GromNaN GromNaN commented Oct 21, 2025

In order to add --do-not-fail-on-deprecation in this doctrine/persistence#454

We can't add it by default as it requires PHPUnit 10.5.47.

Job with phpunit-options-lowest: https://github.com/doctrine/persistence/actions/runs/18695933947/job/53313253004?pr=454

@greg0ire
Copy link
Member

Please send links to jobs that demonstrate the change, as in e.g. #70

@GromNaN
Copy link
Member Author

GromNaN commented Oct 21, 2025

I can't get it to work.

@GromNaN GromNaN force-pushed the phpunit-options branch 3 times, most recently from 440d099 to 96c67e3 Compare October 21, 2025 19:59
@greg0ire
Copy link
Member

I can't get it to work.

Really? Looks to me that you managed to obtain a green build in doctrine/persistence#454

@GromNaN GromNaN changed the title Add phpunit-options Add phpunit-options-lowest to add option to the phpunit command on matrix.dependencies = lowest Oct 21, 2025
@GromNaN
Copy link
Member Author

GromNaN commented Oct 21, 2025

I can't get it to work.

Really? Looks to me that you managed to obtain a green build in doctrine/persistence#454

Yes, fixed. The issue was that matrix.dependencies is not yes set when initializing this action.

@GromNaN GromNaN merged commit 971d725 into doctrine:main Oct 22, 2025
@GromNaN GromNaN deleted the phpunit-options branch October 22, 2025 12:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants