Skip to content

Fix version checking #70

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
greg0ire merged 1 commit into from
Oct 13, 2025
Merged

Fix version checking #70

greg0ire merged 1 commit into from
Oct 13, 2025

Conversation

@greg0ire
Copy link
Member

@greg0ire greg0ire commented Oct 13, 2025 •
edited
Loading

I intended to exclude e.g. 11.5.28 but failed to do so because it is greater than 10.5.49.

Let us instead just check against 10.0.0: if the upgrade fails, it
should be easy to fix it by requiring the correct patch version.

@greg0ire greg0ire mentioned this pull request Oct 13, 2025
Merged
@greg0ire
Copy link
Member Author

greg0ire commented Oct 13, 2025

Draft because I need to test this

GromNaN
GromNaN reviewed Oct 13, 2025
View reviewed changes
Copy link
Member

@GromNaN GromNaN left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I hoped that phpunit would return a different error code depending on whether the command was unavailable or there was a configuration error, but it didn't.

Ideally, this phpunit version constraint should be set in all the packages that use this action, so there would be no need to check here.

@derrabus
Copy link
Member

derrabus commented Oct 13, 2025

Ideally, this phpunit version constraint should be set in all the packages that use this action, so there would be no need to check here.

Our downstream projects should prevent the downgrade of PHPUnit to ancient patch releases in their composer.json. We need to check that we're not on PHPUnit 9 though.

@greg0ire
Copy link
Member Author

greg0ire commented Oct 13, 2025 •
edited
Loading

Our downstream projects should prevent the downgrade of PHPUnit to ancient patch releases in their composer.json. We need to check that we're not on PHPUnit 9 though.

Are you suggesting I should just simplify this to keep the check against 10.5.49? Works for me…
Or even 10.0.0? That way, if the dependabot upgrade fail, we will just have to bump to a big enough PHPUnit version.

@greg0ire
Fix version checking
b41495f 
I intended to exclude e.g. 11.5.28 but failed to do so because it is
greater than 10.5.49.
Let us instead just check against 10.0.0: if the upgrade fails, it
should be easy to fix it by requiring the correct patch version.
@greg0ire greg0ire marked this pull request as ready for review October 13, 2025 11:36
@greg0ire greg0ire requested review from GromNaN and derrabus October 13, 2025 11:36
@derrabus
Copy link
Member

derrabus commented Oct 13, 2025

Are you suggesting I should just simplify this to keep the check against 10.5.49? Works for me… Or even 10.0.0? That way, if the dependabot upgrade fail, we will just have to bump to a big enough PHPUnit version.

Yes, both should work fine.

@greg0ire greg0ire merged commit bc894fb into doctrine:main Oct 13, 2025
@greg0ire greg0ire deleted the fix-comparison branch October 13, 2025 16:12
@greg0ire greg0ire mentioned this pull request Oct 21, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@GromNaN GromNaN GromNaN approved these changes

@derrabus derrabus derrabus approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@greg0ire @derrabus @GromNaN