Skip to content

Conversation

@DigitalBrains1
Copy link
Collaborator

@DigitalBrains1 DigitalBrains1 commented Feb 24, 2024

Closes: #54

This should make the package fit for Stackage again \o/

Drop support for optional template-haskell

PR #44 (part of v0.7.0.7) introduced import Language.Haskell.TH.Syntax (Lift) into System/Console/Docopt/Types.hs which broke this flag. Since all supported GHC versions bundle supported template-haskell libraries, this flag doesn't have a significant purpose anymore, let's simplify.

Tested with cabal v2-test {,--prefer-oldest} on all GHC's from 8.0 to 9.8 (that's 22 scenario's), plus Stack on LTS-22.11 (GHC 9.6) and nightly-2024-02-22 (GHC 9.8).

PR #44 (part of v0.7.0.7) introduced
`import Language.Haskell.TH.Syntax (Lift)` into
`System/Console/Docopt/Types.hs` which broke this flag. Since all
supported GHC versions bundle supported `template-haskell` libraries,
this flag doesn't have a significant purpose anymore, let's simplify.
Copy link
Collaborator

@martijnbastiaan martijnbastiaan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wohoo!

@DigitalBrains1 DigitalBrains1 merged commit 54ce31b into main Feb 24, 2024
@martijnbastiaan martijnbastiaan deleted the containers-upgrade branch February 24, 2024 16:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Update for recent template-haskell

3 participants